Issue 4670 - Add a new build type for Gecko-based WebExtensions

templates/manifest.json.tmpl

 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 {
   "manifest_version": 2,
   {%- if releaseBuild %}
   "name": "__MSG_name__",
   {%- else %}
   "name": "__MSG_name_devbuild__",
@@ skipping 12 matching lines @@
   {%- if metadata.has_section('compat') and metadata.has_option('compat', 'edge') %}
   "minimum_edge_version": {{metadata.get('compat', 'edge')|json}},
   {%- endif %}
 
   {%- if type == 'gecko-webext' %}
   "applications":
   {
     "gecko":
     {
       "id": {{metadata.get('general', 'id')|json}}
       {%- if metadata.has_section('compat') and metadata.has_option('compat', 'gecko') %}

[Sebastian Noack, 2016/12/01 16:24:54]

If I understand correctly this will result into a blank line above the comma
which could be easily avoided by using -%} when closing the jinja tag.

[Wladimir Palant, 2016/12/01 21:39:32]

It doesn't matter because this JSON file is being rewritten by the packager
anyway - none of the whitespace will make it into the build.

       ,
       "strict_min_version": {{metadata.get('compat', 'gecko')|json}}
       {%- endif %}
     }
   },
   {%- endif %}
 
   {%- if pageAction %}
   "page_action": {
     "default_icon": {{pageAction.icon|json}},
@@ skipping 27 matching lines @@
   {%- endif %}
 
   {%- if backgroundScripts %}
   "background": {
     "scripts": {{backgroundScripts|json}},
     "persistent": true
   },
   {%- endif %}
 
   {%- if metadata.has_option('general', 'options') %}
+  {%- if type != 'edge' %}
   "options_ui": {

[Sebastian Noack, 2016/12/01 16:24:54]

Did you test whether this is supported on Microsoft Edge? It seems it is not:
https://developer.microsoft.com/en-us/microsoft-edge/platform/documentation/e...

[Wladimir Palant, 2016/12/01 21:39:31]

You are right, it doesn't. So fallback it is.

     "page": {{metadata.get('general', 'options')|json}},
     "open_in_tab": true
   },
+  {%- else %}
+  "options_page": {{metadata.get('general', 'options')|json}},
+  {%- endif %}
   {%- endif %}
 
   {%- if metadata.has_option('general', 'devtools') %}
   "devtools_page": {{metadata.get('general', 'devtools')|json}},
   {%- endif %}
 
   {%- if contentScripts %}
   "content_scripts": {{contentScripts|json}},
   {%- endif %}
 
   {%- if webAccessible %}
   "web_accessible_resources": {{webAccessible|json}},
   {%- endif %}
 
   {%- if metadata.has_option('general', 'managedStorageSchema') %}
   "storage": {
     "managed_schema": {{metadata.get('general', 'managedStorageSchema')|json}}
   },
   {%- endif %}
 
   "_dummy": false
 }