Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: templates/manifest.json.tmpl

Issue 29365583: Issue 4670 - Add a new build type for Gecko-based WebExtensions (Closed) Base URL: https://hg.adblockplus.org/buildtools
Left Patch Set: Addressed comments Created Dec. 1, 2016, 9:38 p.m.
Right Patch Set: Split out info module into a Chrome and Gecko specific one Created Dec. 3, 2016, 7:02 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « templates/geckoInfo.js.tmpl ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* This Source Code Form is subject to the terms of the Mozilla Public 1 /* This Source Code Form is subject to the terms of the Mozilla Public
2 * License, v. 2.0. If a copy of the MPL was not distributed with this 2 * License, v. 2.0. If a copy of the MPL was not distributed with this
3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ 3 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
4 4
5 { 5 {
6 "manifest_version": 2, 6 "manifest_version": 2,
7 {%- if releaseBuild %} 7 {%- if releaseBuild %}
8 "name": "__MSG_name__", 8 "name": "__MSG_name__",
9 {%- else %} 9 {%- else %}
10 "name": "__MSG_name_devbuild__", 10 "name": "__MSG_name_devbuild__",
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 {%- endif %} 71 {%- endif %}
72 72
73 {%- if backgroundScripts %} 73 {%- if backgroundScripts %}
74 "background": { 74 "background": {
75 "scripts": {{backgroundScripts|json}}, 75 "scripts": {{backgroundScripts|json}},
76 "persistent": true 76 "persistent": true
77 }, 77 },
78 {%- endif %} 78 {%- endif %}
79 79
80 {%- if metadata.has_option('general', 'options') %} 80 {%- if metadata.has_option('general', 'options') %}
81 {%- if type != 'edge' %}
81 "options_ui": { 82 "options_ui": {
82 "page": {{metadata.get('general', 'options')|json}}, 83 "page": {{metadata.get('general', 'options')|json}},
83 "open_in_tab": true 84 "open_in_tab": true
84 }, 85 },
85 {# Edge doesn't support options_ui so we specify options_page as well #} 86 {%- else %}
Sebastian Noack 2016/12/02 11:47:50 Since the target platform is known here, perhaps i
Wladimir Palant 2016/12/03 19:02:56 Done.
86 "options_page": {{metadata.get('general', 'options')|json}}, 87 "options_page": {{metadata.get('general', 'options')|json}},
88 {%- endif %}
87 {%- endif %} 89 {%- endif %}
88 90
89 {%- if metadata.has_option('general', 'devtools') %} 91 {%- if metadata.has_option('general', 'devtools') %}
90 "devtools_page": {{metadata.get('general', 'devtools')|json}}, 92 "devtools_page": {{metadata.get('general', 'devtools')|json}},
91 {%- endif %} 93 {%- endif %}
92 94
93 {%- if contentScripts %} 95 {%- if contentScripts %}
94 "content_scripts": {{contentScripts|json}}, 96 "content_scripts": {{contentScripts|json}},
95 {%- endif %} 97 {%- endif %}
96 98
97 {%- if webAccessible %} 99 {%- if webAccessible %}
98 "web_accessible_resources": {{webAccessible|json}}, 100 "web_accessible_resources": {{webAccessible|json}},
99 {%- endif %} 101 {%- endif %}
100 102
101 {%- if metadata.has_option('general', 'managedStorageSchema') %} 103 {%- if metadata.has_option('general', 'managedStorageSchema') %}
102 "storage": { 104 "storage": {
103 "managed_schema": {{metadata.get('general', 'managedStorageSchema')|json}} 105 "managed_schema": {{metadata.get('general', 'managedStorageSchema')|json}}
104 }, 106 },
105 {%- endif %} 107 {%- endif %}
106 108
107 "_dummy": false 109 "_dummy": false
108 } 110 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld