Unified Diff: packagerChrome.py
Issue 29365583:
Issue 4670 - Add a new build type for Gecko-based WebExtensions (Closed)
Base URL: https://hg.adblockplus.org/buildtools
Patch Set: Updated the way options page is specified in the manifest
Created Nov. 30, 2016, 1:23 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« build.py ('K')
|
« build.py ('k')
|
templates/chromeInfo.js.tmpl » ('j')
|
templates/chromeInfo.js.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: packagerChrome.py |
| =================================================================== |
| --- a/packagerChrome.py |
| +++ b/packagerChrome.py |
| @@ -330,17 +330,21 @@ def writePackage(outputFile, pubkey, sig |
| file.write(zipdata) |
| def createBuild(baseDir, type='chrome', outFile=None, buildNum=None, releaseBuild=False, keyFile=None, devenv=False): |
| metadata = readMetadata(baseDir, type) |
| version = getBuildVersion(baseDir, metadata, releaseBuild, buildNum) |
| if outFile == None: |
| - outFile = getDefaultFileName(metadata, version, 'crx' if keyFile else 'zip') |
| + if type == 'gecko-webext': |
| + file_extension = 'xpi' |
|
Sebastian Noack
2016/12/01 16:24:54
So do I understand correctly, that WebExtensions f
Wladimir Palant
2016/12/01 21:39:31
Yes, there is only a difference for signed package
|
| + else: |
| + file_extension = 'crx' if keyFile else 'zip' |
| + outFile = getDefaultFileName(metadata, version, file_extension) |
| params = { |
| 'type': type, |
| 'baseDir': baseDir, |
| 'releaseBuild': releaseBuild, |
| 'version': version, |
| 'devenv': devenv, |
| 'metadata': metadata, |
« build.py ('K')
|
« build.py ('k')
|
templates/chromeInfo.js.tmpl » ('j')
|
templates/chromeInfo.js.tmpl » ('J')
