Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: templates/manifest.json.tmpl

Issue 29365583: Issue 4670 - Add a new build type for Gecko-based WebExtensions (Closed) Base URL: https://hg.adblockplus.org/buildtools
Patch Set: Addressed comments Created Dec. 1, 2016, 9:38 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« templates/chromeInfo.js.tmpl ('K') | « templates/chromeInfo.js.tmpl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: templates/manifest.json.tmpl
===================================================================
--- a/templates/manifest.json.tmpl
+++ b/templates/manifest.json.tmpl
@@ -19,16 +19,30 @@
{%- if metadata.has_section('compat') and metadata.has_option('compat', 'chrome') %}
"minimum_chrome_version": {{metadata.get('compat', 'chrome')|json}},
{%- endif %}
{%- if metadata.has_section('compat') and metadata.has_option('compat', 'edge') %}
"minimum_edge_version": {{metadata.get('compat', 'edge')|json}},
{%- endif %}
+ {%- if type == 'gecko-webext' %}
+ "applications":
+ {
+ "gecko":
+ {
+ "id": {{metadata.get('general', 'id')|json}}
+ {%- if metadata.has_section('compat') and metadata.has_option('compat', 'gecko') %}
+ ,
+ "strict_min_version": {{metadata.get('compat', 'gecko')|json}}
+ {%- endif %}
+ }
+ },
+ {%- endif %}
+
{%- if pageAction %}
"page_action": {
"default_icon": {{pageAction.icon|json}},
{%- if pageAction.popup %}
"default_popup": {{pageAction.popup|json}},
{%- endif %}
"default_title": "__MSG_name__"
},
@@ -59,16 +73,21 @@
{%- if backgroundScripts %}
"background": {
"scripts": {{backgroundScripts|json}},
"persistent": true
},
{%- endif %}
{%- if metadata.has_option('general', 'options') %}
+ "options_ui": {
+ "page": {{metadata.get('general', 'options')|json}},
+ "open_in_tab": true
+ },
+ {# Edge doesn't support options_ui so we specify options_page as well #}
Sebastian Noack 2016/12/02 11:47:50 Since the target platform is known here, perhaps i
Wladimir Palant 2016/12/03 19:02:56 Done.
"options_page": {{metadata.get('general', 'options')|json}},
{%- endif %}
{%- if metadata.has_option('general', 'devtools') %}
"devtools_page": {{metadata.get('general', 'devtools')|json}},
{%- endif %}
{%- if contentScripts %}
« templates/chromeInfo.js.tmpl ('K') | « templates/chromeInfo.js.tmpl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld