Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29365771: Issue 4673 - Add a WebExtensions build configuration (Closed)

Created:
Nov. 30, 2016, 10:28 a.m. by Wladimir Palant
Modified:
Dec. 3, 2016, 9:31 p.m.
Reviewers:
kzar
CC:
Sebastian Noack
Base URL:
https://hg.adblockplus.org/adblockpluschrome
Visibility:
Public.

Description

Issue 4673 - Add a WebExtensions build configuration

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed pop-up blocking module, relevant platform functionality is unimplemented in Firefox #

Patch Set 3 : Updated dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M .hgignore View 1 chunk +1 line, -0 lines 0 comments Download
M dependencies View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A metadata.gecko-webext View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
https://codereview.adblockplus.org/29365771/diff/29365772/dependencies File dependencies (right): https://codereview.adblockplus.org/29365771/diff/29365772/dependencies#newcode3 dependencies:3: buildtools = buildtools hg:tip git:5b7b921 I will add a ...
Nov. 30, 2016, 10:32 a.m. (2016-11-30 10:32:36 UTC) #1
kzar
Once buildtools dependency is fixed LGTM.
Nov. 30, 2016, 10:52 a.m. (2016-11-30 10:52:45 UTC) #2
Wladimir Palant
Dec. 3, 2016, 9:30 p.m. (2016-12-03 21:30:57 UTC) #3
I've updated the dependency now that the buildtools change landed.

Powered by Google App Engine
This is Rietveld