metadata.gecko-webext - Issue 29365771: Issue 4673 - Add a WebExtensions build configuration

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.gecko-webext

Issue 29365771: Issue 4673 - Add a WebExtensions build configuration (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome

Left Patch Set: Created Nov. 30, 2016, 10:28 a.m.

Right Patch Set: Updated dependency Created Dec. 3, 2016, 9:26 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [default]	1 [default]

2 inherit = metadata.chrome	2 inherit = metadata.chrome

3	3

4 [general]	4 [general]

5 id={d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}	5 id={d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}

6 basename = adblockplusfirefox	6 basename = adblockplusfirefox
Wladimir Palant 2016/11/30 10:32:35 Note: while the extension ID is the same, basename Note: while the extension ID is the same, basename is intentionally different from our classic extension which goes by the internal name "adblockplus."
7	7

8 [compat]	8 [compat]

9 gecko = 50.0	9 gecko = 50.0
Wladimir Palant 2016/11/30 10:32:35 I assume that we won't bother with backwards compa I assume that we won't bother with backwards compatibility here so I set this to the current stable release. It is likely that we will require an even newer release in future, with important WebExtensions bugs still being fixed.
	10

	11 [convert_js]

	12 # See https://bugzil.la/1190687 - pop-up blocking won't work right now

	13 lib/adblockplus.js -= lib/popupBlocker.js

LEFT	RIGHT