Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(467)

Issue 29365801: Issue 4676 - Replace non-standard CSSStyleSheet.addRule() call by CSSStyleSheet.insertRule() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by Wladimir Palant
Modified:
3 years, 1 month ago
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome
Visibility:
Public.

Description

Issue 4676 - Replace non-standard CSSStyleSheet.addRule() call by CSSStyleSheet.insertRule()

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M include.preload.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
Wladimir Palant
3 years, 1 month ago (2016-11-30 13:37:17 UTC) #1
kzar
Otherwise LGTM https://codereview.adblockplus.org/29365801/diff/29365802/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29365801/diff/29365802/include.preload.js#newcode584 include.preload.js:584: this.style.sheet.cssRules.length); Nit: The indentation of this line ...
3 years, 1 month ago (2016-11-30 13:48:20 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29365801/diff/29365802/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29365801/diff/29365802/include.preload.js#newcode584 include.preload.js:584: this.style.sheet.cssRules.length); On 2016/11/30 13:48:20, kzar wrote: > Nit: The ...
3 years, 1 month ago (2016-11-30 13:52:11 UTC) #3
kzar
3 years, 1 month ago (2016-11-30 14:40:22 UTC) #4
Message was sent while issue was closed.
LGTM++
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5