Issue 4616 - Push Edge related changes to the edge bookmark of adblockpluschrome

README.md

 Adblock Plus for Chrome, Opera and Safari
 =========================================
 
 This repository contains the platform-specific Adblock Plus source code for
 Chrome, Opera and Safari. It can be used to build Adblock Plus for these
 platforms, generic Adblock Plus code will be extracted from other repositories
 automatically (see _dependencies_ file).
 
 Building
 ---------
 
 ### Requirements
 
 - [Mercurial](https://www.mercurial-scm.org/) or [Git](https://git-scm.com/) (whichever you used to clone this repository)
 - [Python 2.7](https://www.python.org)
 - [The Jinja2 module](http://jinja.pocoo.org/docs)
 - [The PIL module](http://www.pythonware.com/products/pil/)
 - For signed builds: [PyCrypto module](https://www.dlitz.net/software/pycrypto/)
 
 ### Building the extension
 
 Run one of the following commands in the project directory, depending on your
 target platform:
 
     ./build.py -t chrome build -k adblockpluschrome.pem
     ./build.py -t safari build -k adblockplussafari.pem
+    ./build.py -t edge build
 
 This will create a build with a name in the form
-_adblockpluschrome-1.2.3.nnnn.crx_ or _adblockplussafari-1.2.3.nnnn.safariextz_.
+_adblockpluschrome-1.2.3.nnnn.crx_ or _adblockplussafari-1.2.3.nnnn.safariextz_

[kzar, 2016/12/01 12:11:01]

Nit: The second "or" should now be a comma I guess.

[Oleksandr, 2016/12/01 14:18:04]

Isn't it better with first "or" changed to comma?

[kzar, 2016/12/01 14:23:06]

Yes, whoops that's what I meant.

+or adblockplusedge-1.2.3.nnnn.appx.
 Note that you don't need an existing signing key for Chrome, a new key
 will be created automatically if the file doesn't exist. Safari on the other
 hand always requires a valid developer certificate, you need to get one in the
 Apple Developer Center first. _adblockplussafari.pem_ should contain the private
 key for your developer certificate, the developer certificate itself as well as
 all the certificates it was signed with (Apple's root certificate and
 intermediate certificates) in PEM format - in that order.
 
 ### Development environment
 
 To simplify the process of testing your changes you can create an unpacked
 development environment. For that run one of the following commands:
 
     ./build.py -t chrome devenv
     ./build.py -t safari devenv
 
 This will create a _devenv.platform_ directory in the repository. In Chrome you
 should load _devenv.chrome_ as an unpacked extension directory. After making
 changes to the source code re-run the command to update the development
 environment, the extension should reload automatically after a few seconds.
 
 In Safari you should load _devenv.safari/adblockplussafari.safariextension_ as
 unpacked extension directory. After making changes to the source code re-run the
 command to update the development environment. You will still need to reload the
 extension explicitly in the Extension Builder, Safari currently doesn't allow
 automating this action.
 
+In Edge you should load _devenv.chrome as unpacked extension directory. After

[kzar, 2016/12/01 12:11:01]

I think this paragraph should be above the Safari one. Also I think it should
start with a sentence explaining that the Edge platform does not have it's own
devenv command and that the Chrome one should be used instead.

[kzar, 2016/12/01 12:11:01]

Nit: Missing the underscore after "devenv.chrome".

[Oleksandr, 2016/12/01 14:18:04]

Done.

[Oleksandr, 2016/12/01 14:18:04]

Done.

+rebuilding the extension you should usually force reloading it in Edge.
+
 Running the unit tests
 ----------------------
 
 To verify your changes you can use the unit test suite located in the _qunit_
 directory of the repository. In order to run the unit tests go to the
 extension's Options page, open the JavaScript Console and type in:
 
     location.href = "qunit/index.html";
 
 The unit tests will run automatically once the page loads.