Issue 4616 - Push Edge related changes to the edge bookmark of adblockpluschrome

README.md

-Adblock Plus for Chrome and Opera

[kzar, 2016/12/16 10:40:14]

Please change this title to add Edge.

-=================================
+Adblock Plus for Chrome, Opera and Edge
+=======================================
 
 This repository contains the platform-specific Adblock Plus source code for
 Chrome, Opera and Edge. It can be used to build Adblock Plus for these
 platforms, generic Adblock Plus code will be extracted from other repositories
 automatically (see _dependencies_ file).
 
 Building
 ---------
 
 ### Requirements
 
 - [Mercurial](https://www.mercurial-scm.org/) or [Git](https://git-scm.com/) (whichever you used to clone this repository)
 - [Python 2.7](https://www.python.org)
 - [The Jinja2 module](http://jinja.pocoo.org/docs) (>= 2.8)
 - [The PIL module](http://www.pythonware.com/products/pil/)
 - For signed builds: [PyCrypto module](https://www.dlitz.net/software/pycrypto/)
 
 ### Building the extension
 
-Run the following command in the project directory:

[kzar, 2016/12/16 10:40:14]

There are more than one commands now, but this still uses the singular
"command". (See Patch Set 1, before the rebase, for how it should be.)

+Run one of the following commands in the project directory, depending on your
+target platform:
 
     ./build.py -t chrome build -k adblockpluschrome.pem
     ./build.py -t edge build
 
 This will create a build with a name in the form
-_adblockpluschrome-1.2.3.nnnn.crx_ or adblockplusedge-1.2.3.nnnn.appx.
+_adblockpluschrome-1.2.3.nnnn.crx_ or _adblockplusedge-1.2.3.nnnn.appx_.
 Note that you don't need an existing signing key for Chrome, a new key
 will be created automatically if the file doesn't exist.
 
 ### Development environment
 
 To simplify the process of testing your changes you can create an unpacked
-development environment. For that run the following command:

[kzar, 2016/12/16 10:40:14]

Same here, there are now multiple commands.

+development environment. For that run one of the following commands:
 
     ./build.py -t chrome devenv
     ./build.py -t edge devenv
 
-This will create a _devenv.chrome_ directory in the repository. In Chrome you

[kzar, 2016/12/16 10:40:14]

This is wrong now, since it will create either a _devenv.chrome_ directory or a
_devenv.edge_ directory depending on the command. Again see the Patch set 1
before the rebase.

-should load the directory as an unpacked extension. After making changes to the
-source code re-run the command to update the development environment, the
-extension should reload automatically after a few seconds.
+This will create a _devenv.platform_ directory in the repository. In Chrome you
+should load _devenv.chrome_ as an unpacked extension directory. After making
+changes to the source code re-run the command to update the development
+environment, the extension should reload automatically after a few seconds.
 
-For Edge you should load _devenv.edge/Extension_ as an unpacked extension directory. After

[kzar, 2016/12/16 10:40:14]

Nit: This line is too long, please wrap at 80 characters.

-rebuilding the extension you should usually force reloading it in Edge.

[kzar, 2016/12/16 10:40:14]

Please be a bit more specific here about when + how you should force reload. (If
you should always force a reload then just say that.) Maybe mention why it's
required too?

+For Edge you should load _devenv.edge/Extension_ as an unpacked extension
+directory. Edge build does not automatically detect changes, so after
+rebuilding the extension you should manually force reloading it in Edge by
+hitting the _Reload Extension_ button.
 
 Running the unit tests
 ----------------------
 
 To verify your changes you can use the unit test suite located in the _qunit_
 directory of the repository. In order to run the unit tests go to the
 extension's Options page, open the JavaScript Console and type in:
 
     location.href = "qunit/index.html";
 
 The unit tests will run automatically once the page loads.