Delta Between Two Patch Sets: README.md
Issue 29365879:
Issue 4616 - Push Edge related changes to the edge bookmark of adblockpluschrome (Closed)
Left Patch Set: Adapt the README.md
Created Dec. 19, 2016, 11:42 a.m.
Right Patch Set: Hardcode the version number for Edge
Created Dec. 19, 2016, 2:46 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
icons/abp-150.png » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 Adblock Plus for Chrome and Opera and Edge | 1 Adblock Plus for Chrome, Opera and Edge |
|
kzar
2016/12/19 13:34:17
Nit: Second "and" should be a comma.
Oleksandr
2016/12/19 14:12:13
Done.
| |
| 2 ========================================== | 2 ======================================= |
| 3 | 3 |
| 4 This repository contains the platform-specific Adblock Plus source code for | 4 This repository contains the platform-specific Adblock Plus source code for |
| 5 Chrome, Opera and Edge. It can be used to build Adblock Plus for these | 5 Chrome, Opera and Edge. It can be used to build Adblock Plus for these |
| 6 platforms, generic Adblock Plus code will be extracted from other repositories | 6 platforms, generic Adblock Plus code will be extracted from other repositories |
| 7 automatically (see _dependencies_ file). | 7 automatically (see _dependencies_ file). |
| 8 | 8 |
| 9 Building | 9 Building |
| 10 --------- | 10 --------- |
| 11 | 11 |
| 12 ### Requirements | 12 ### Requirements |
| 13 | 13 |
| 14 - [Mercurial](https://www.mercurial-scm.org/) or [Git](https://git-scm.com/) (wh ichever you used to clone this repository) | 14 - [Mercurial](https://www.mercurial-scm.org/) or [Git](https://git-scm.com/) (wh ichever you used to clone this repository) |
| 15 - [Python 2.7](https://www.python.org) | 15 - [Python 2.7](https://www.python.org) |
| 16 - [The Jinja2 module](http://jinja.pocoo.org/docs) (>= 2.8) | 16 - [The Jinja2 module](http://jinja.pocoo.org/docs) (>= 2.8) |
| 17 - [The PIL module](http://www.pythonware.com/products/pil/) | 17 - [The PIL module](http://www.pythonware.com/products/pil/) |
| 18 - For signed builds: [PyCrypto module](https://www.dlitz.net/software/pycrypto/) | 18 - For signed builds: [PyCrypto module](https://www.dlitz.net/software/pycrypto/) |
| 19 | 19 |
| 20 ### Building the extension | 20 ### Building the extension |
| 21 | 21 |
| 22 Run one of the following commands in the project directory, depending on your | 22 Run one of the following commands in the project directory, depending on your |
| 23 target platform: | 23 target platform: |
| 24 | 24 |
| 25 ./build.py -t chrome build -k adblockpluschrome.pem | 25 ./build.py -t chrome build -k adblockpluschrome.pem |
| 26 ./build.py -t edge build | 26 ./build.py -t edge build |
| 27 | 27 |
| 28 This will create a build with a name in the form | 28 This will create a build with a name in the form |
| 29 _adblockpluschrome-1.2.3.nnnn.crx_ or adblockplusedge-1.2.3.nnnn.appx. | 29 _adblockpluschrome-1.2.3.nnnn.crx_ or _adblockplusedge-1.2.3.nnnn.appx_. |
|
kzar
2016/12/19 13:34:17
Please surround the example edge filename with und
Oleksandr
2016/12/19 14:12:13
Done.
| |
| 30 Note that you don't need an existing signing key for Chrome, a new key | 30 Note that you don't need an existing signing key for Chrome, a new key |
| 31 will be created automatically if the file doesn't exist. | 31 will be created automatically if the file doesn't exist. |
| 32 | 32 |
| 33 ### Development environment | 33 ### Development environment |
| 34 | 34 |
| 35 To simplify the process of testing your changes you can create an unpacked | 35 To simplify the process of testing your changes you can create an unpacked |
| 36 development environment. For that run one of the following commands: | 36 development environment. For that run one of the following commands: |
| 37 | 37 |
| 38 ./build.py -t chrome devenv | 38 ./build.py -t chrome devenv |
| 39 ./build.py -t edge devenv | 39 ./build.py -t edge devenv |
| (...skipping 11 matching lines...) Expand all Loading... | |
| 51 Running the unit tests | 51 Running the unit tests |
| 52 ---------------------- | 52 ---------------------- |
| 53 | 53 |
| 54 To verify your changes you can use the unit test suite located in the _qunit_ | 54 To verify your changes you can use the unit test suite located in the _qunit_ |
| 55 directory of the repository. In order to run the unit tests go to the | 55 directory of the repository. In order to run the unit tests go to the |
| 56 extension's Options page, open the JavaScript Console and type in: | 56 extension's Options page, open the JavaScript Console and type in: |
| 57 | 57 |
| 58 location.href = "qunit/index.html"; | 58 location.href = "qunit/index.html"; |
| 59 | 59 |
| 60 The unit tests will run automatically once the page loads. | 60 The unit tests will run automatically once the page loads. |
| LEFT | RIGHT |
« no previous file
|
icons/abp-150.png » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
