Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: README.md

Issue 29365879: Issue 4616 - Push Edge related changes to the edge bookmark of adblockpluschrome (Closed)
Patch Set: Refresh README.md Created Dec. 14, 2016, 2:05 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | icons/abp-150.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.md
===================================================================
--- a/README.md
+++ b/README.md
@@ -2,8 +2,8 @@
=================================
This repository contains the platform-specific Adblock Plus source code for
-Chrome and Opera. It can be used to build Adblock Plus for these platforms,
-generic Adblock Plus code will be extracted from other repositories
+Chrome, Opera and Edge. It can be used to build Adblock Plus for these
+platforms, generic Adblock Plus code will be extracted from other repositories
automatically (see _dependencies_ file).
Building
@@ -22,9 +22,10 @@
Run the following command in the project directory:
kzar 2016/12/16 10:40:14 There are more than one commands now, but this sti
./build.py -t chrome build -k adblockpluschrome.pem
+ ./build.py -t edge build
This will create a build with a name in the form
-_adblockpluschrome-1.2.3.nnnn.crx_
+_adblockpluschrome-1.2.3.nnnn.crx_ or adblockplusedge-1.2.3.nnnn.appx.
Note that you don't need an existing signing key for Chrome, a new key
will be created automatically if the file doesn't exist.
@@ -34,12 +35,16 @@
development environment. For that run the following command:
kzar 2016/12/16 10:40:14 Same here, there are now multiple commands.
./build.py -t chrome devenv
+ ./build.py -t edge devenv
This will create a _devenv.chrome_ directory in the repository. In Chrome you
kzar 2016/12/16 10:40:14 This is wrong now, since it will create either a _
should load the directory as an unpacked extension. After making changes to the
source code re-run the command to update the development environment, the
extension should reload automatically after a few seconds.
+For Edge you should load _devenv.edge/Extension_ as an unpacked extension directory. After
kzar 2016/12/16 10:40:14 Nit: This line is too long, please wrap at 80 char
+rebuilding the extension you should usually force reloading it in Edge.
kzar 2016/12/16 10:40:14 Please be a bit more specific here about when + ho
+
Running the unit tests
----------------------
« no previous file with comments | « no previous file | icons/abp-150.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld