Issue 2879 - Make "view source" command work again

lib/aardvark.js

 /*
  * This Source Code is subject to the terms of the Mozilla Public License
  * version 2.0 (the "License"). You can obtain a copy of the License at
  * http://mozilla.org/MPL/2.0/.
  */
 
 let {Services} = Cu.import("resource://gre/modules/Services.jsm", {});
 
 let {Prefs} = require("prefs");
 
@@ skipping 367 matching lines @@
 
       this.appendDescription(startTag, "<", null);
       this.appendDescription(startTag, node.tagName, "tagName");
 
       for (let {name, value} of node.attributes)
       {
         this.appendDescription(startTag, name, "attrName");
         if (value != "")
         {
           this.appendDescription(startTag, "=", null);
-          this.appendDescription(startTag, '"' + value.replace(/"/, "&quot;") + '"', "attrValue");

[saroyanm, 2016/12/05 17:51:47]

Detail: exceeds 80 characters.

[Wladimir Palant, 2016/12/08 13:11:29]

Done.

+          this.appendDescription(startTag, `"${value.replace(/"/, """)}"`,
+                                 "attrValue");
         }
       }
 
       this.appendDescription(startTag, node.children.length ? ">" : " />", null);
       box.appendChild(startTag);
 
       if (node.children.length)
       {
         for (let child of node.children)
           this.getOuterHtmlFormatted(child, box);
@@ skipping 13 matching lines @@
     if (text == "")
       return;
 
     text = text.replace(/&/g, "&")
                .replace(/</g, "&lt;")
                .replace(/>/g, "&gt;")
                .replace(/\t/g, "  ");
     if (type == "comment")
       text = "<!--" + text + "-->";
 
-    let lines = text.split("\n");

[saroyanm, 2016/12/05 17:51:47]

detail: we can move this inside of for statement, not sure if this provide much
readability value.

[Wladimir Palant, 2016/12/08 13:11:29]

Done.

-    for (let line of lines)
+    for (let line of text.split("\n"))
       this.appendDescription(container, line.trim(), type);
   },
 
   showMenu: function()
   {
     var helpBox = E("ehh-helpbox");
     if (helpBox.state == "open")
     {
       helpBox.hidePopup();
       return true;
     }
 
     // Show help box
     helpBox.showPopup(this.browser, -1, -1, "tooltip", "topleft", "topleft");
     return true;
   }
 }
 
 // Makes sure event handlers like Aardvark.onKeyPress always have the correct
 // this pointer set.
 for (let method of ["onKeyPress", "onMouseMove", "onTabSelect"])
   Aardvark[method] = Aardvark[method].bind(Aardvark);