Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29366556: Issue 2879 - Make "view source in separate window" command work again (Closed)

Created:
Dec. 1, 2016, 11:03 a.m. by Wladimir Palant
Modified:
Dec. 20, 2016, 3:08 p.m.
Reviewers:
saroyanm
Base URL:
https://hg.adblockplus.org/elemhidehelper
Visibility:
Public.

Description

Issue 2879 - Make "view source in separate window" command work again

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -22 lines) Patch
M lib/aardvark.js View 2 chunks +14 lines, -22 lines 3 comments Download
M lib/child/commands.js View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Dec. 1, 2016, 11:03 a.m. (2016-12-01 11:03:13 UTC) #1
saroyanm
LGTM with small nit. https://codereview.adblockplus.org/29366556/diff/29366557/lib/aardvark.js File lib/aardvark.js (right): https://codereview.adblockplus.org/29366556/diff/29366557/lib/aardvark.js#newcode342 lib/aardvark.js:342: drawSelection: false, Nit: not aligned ...
Dec. 5, 2016, 6:02 p.m. (2016-12-05 18:02:51 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29366556/diff/29366557/lib/aardvark.js File lib/aardvark.js (right): https://codereview.adblockplus.org/29366556/diff/29366557/lib/aardvark.js#newcode342 lib/aardvark.js:342: drawSelection: false, On 2016/12/05 18:02:51, saroyanm wrote: > Nit: ...
Dec. 8, 2016, 1:04 p.m. (2016-12-08 13:04:16 UTC) #3
saroyanm
Dec. 20, 2016, 2:32 p.m. (2016-12-20 14:32:05 UTC) #4
LGTM

https://codereview.adblockplus.org/29366556/diff/29366557/lib/aardvark.js
File lib/aardvark.js (right):

https://codereview.adblockplus.org/29366556/diff/29366557/lib/aardvark.js#new...
lib/aardvark.js:342: drawSelection: false,
On 2016/12/08 13:04:16, Wladimir Palant wrote:
> On 2016/12/05 18:02:51, saroyanm wrote:
> > Nit: not aligned with the line above.
> 
> It shouldn't be - the line above is indented to indicate that it all belongs
to
> the URI key.

Acknowledged.

Powered by Google App Engine
This is Rietveld