chrome/content/firstrun/index.html - Issue 29366570: Issue 4681 - Move URL Fixer first-run page into the extension

Delta Between Two Patch Sets: chrome/content/firstrun/index.html

Issue 29366570: Issue 4681 - Move URL Fixer first-run page into the extension (Closed) Base URL: https://hg.adblockplus.org/urlfixer

Left Patch Set: Created Dec. 1, 2016, 1:05 p.m.

Right Patch Set: Updated license Created Dec. 8, 2016, 1:01 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Installation Successful! \| URL Fixer</title>	4 <title>Installation Successful! \| URL Fixer</title>

5 <link href="reset.css" rel="stylesheet" type="text/css" />	5 <link href="reset.css" rel="stylesheet" type="text/css" />

6 <link href="style.css" rel="stylesheet" type="text/css" />	6 <link href="style.css" rel="stylesheet" type="text/css" />

7 <link href="fancybox/jquery.fancybox-1.3.4.css" rel="stylesheet" type="text/ css" />	7 <link href="fancybox/jquery.fancybox-1.3.4.css" rel="stylesheet" type="text/ css" />

8 <script type="text/javascript" src="jquery-1.7.1.min.js"></script>	8 <script type="text/javascript" src="jquery-1.7.1.min.js"></script>

9 <script type="text/javascript" src="fancybox/jquery.fancybox-1.3.4.pack.js"> </script>	9 <script type="text/javascript" src="fancybox/jquery.fancybox-1.3.4.pack.js"> </script>
Wladimir Palant 2016/12/01 13:13:43 I changed the paths above to relative, same with t I changed the paths above to relative, same with the screenshots below.
10	10

11 <script type="text/javascript">	11 <script type="text/javascript">

12 $(document).ready(function()	12 $(document).ready(function()

13 {	13 {

14 $("a.lightbox").fancybox({	14 $("a.lightbox").fancybox({

15 overlayColor: "#000",	15 overlayColor: "#000",

16 transitionIn: "elastic",	16 transitionIn: "elastic",

17 transitionOut: "elastic",	17 transitionOut: "elastic",

18 titlePosition: "outside"	18 titlePosition: "outside"

19 });	19 });

20 });	20 });
Wladimir Palant 2016/12/01 13:13:43 There was some additional logic related to the dat There was some additional logic related to the data collection opt-in here - I removed it along with the corresponding text block, we are removing data collection functionality.
21 </script>	21 </script>

22	22

23 <style type="text/css">	23 <style type="text/css">

24 #thumbnails	24 #thumbnails

25 {	25 {

26 margin: 0px 20px;	26 margin: 0px 20px;

27 float: right;	27 float: right;

28 }	28 }

29 #thumbnails a	29 #thumbnails a

30 {	30 {

(...skipping 66 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
97 you'll never see that error page again.	97 you'll never see that error page again.

98 <a href="screenshot4-big.png" class="lightbox">(screenshot)</a>	98 <a href="screenshot4-big.png" class="lightbox">(screenshot)</a>

99 </p>	99 </p>

100	100

101 <div class="clear"></div>	101 <div class="clear"></div>

102 </div>	102 </div>

103 </div>	103 </div>

104	104

105 <div id="footer">	105 <div id="footer">

106 <p>	106 <p>

107 Open-source software released under <a href="http://www.mozilla.org/MP L/1.1/">Mozilla Public License</a>	107 Open-source software released under <a href="http://www.gnu.org/licens es/gpl.html">GNU General Public License version 3</a>
Thomas Greiner 2016/12/07 16:08:32 We're using GPLv3 for URL Fixer, aren't we? Based We're using GPLv3 for URL Fixer, aren't we? Based on this it looks like we forgot to mention that on the website when we changed its license. Wladimir Palant 2016/12/08 13:02:23 Done. Show quoted text On 2016/12/07 16:08:32, Thomas Greiner wrote: > We're using GPLv3 for URL Fixer, aren't we? Based on this it looks like we > forgot to mention that on the website when we changed its license. Done.
108 \|	108 \|

109 <a href="https://addons.mozilla.org/addon/url-fixer/privacy/">Privacy Policy</a>	109 <a href="https://addons.mozilla.org/addon/url-fixer/privacy/">Privacy Policy</a>
Wladimir Palant 2016/12/01 13:13:43 There was an imprint link here, I removed it given There was an imprint link here, I removed it given that this isn't a web page any more.
110 </p>	110 </p>

111 <div class="clear"></div>	111 <div class="clear"></div>

112 </div>	112 </div>

113 </div>	113 </div>

114 </body>	114 </body>

115 </html>	115 </html>

LEFT	RIGHT