Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1304)

Issue 29366656: Issue 4683 - URL Fixer breaks location bar input when disabled (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 7 months ago by Wladimir Palant
Modified:
2 years, 7 months ago
Reviewers:
Thomas Greiner
Base URL:
https://hg.adblockplus.org/urlfixer
Visibility:
Public.

Description

Issue 4683 - URL Fixer breaks location bar input when disabled

Patch Set 1 #

Patch Set 2 : Do not modify urlbar variable #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M lib/typoAppIntegration.js View 1 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 3
Wladimir Palant
2 years, 7 months ago (2016-12-01 13:50:27 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29366656/diff/29366684/lib/typoAppIntegration.js File lib/typoAppIntegration.js (right): https://codereview.adblockplus.org/29366656/diff/29366684/lib/typoAppIntegration.js#newcode120 lib/typoAppIntegration.js:120: urlbar : Object.getPrototypeOf(urlbar)); Actually, with urlbar variable being used ...
2 years, 7 months ago (2016-12-01 14:02:43 UTC) #2
Thomas Greiner
2 years, 7 months ago (2016-12-01 14:39:59 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5