Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(55)

Issue 29366707: Issue 3574 - Remove obsolete sshkey realization in class statsmaster (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by mathias
Modified:
2 years, 11 months ago
Reviewers:
f.nicolaisen, f.lopez
CC:
Fred
Visibility:
Public.

Description

Became obsolete in the context of https://issues.adblockplus.org/ticket/3638 with the introduction of modules/adblockplus/host/statsmaster.pp --

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M modules/statsmaster/manifests/init.pp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5
mathias
2 years, 11 months ago (2016-12-01 16:45:16 UTC) #1
f.lopez
On 2016/12/01 16:45:16, mathias wrote: LGTM
2 years, 11 months ago (2016-12-02 14:47:53 UTC) #2
f.nicolaisen
I think I get the reasoning (I see the lines but not the picture), but ...
2 years, 11 months ago (2016-12-02 15:02:57 UTC) #3
mathias
On 2016/12/02 15:02:57, f.nicolaisen wrote: > Another thing: Do you have a commit message we ...
2 years, 11 months ago (2016-12-02 15:28:13 UTC) #4
f.nicolaisen
2 years, 11 months ago (2016-12-02 15:32:42 UTC) #5
On 2016/12/02 15:28:13, mathias wrote:
> On 2016/12/02 15:02:57, f.nicolaisen wrote:
> > Another thing: Do you have a commit message we can review to go with it?
> 
> The title of this very review (plus the "in" which I forgot during the upload
> but added in the GUI afterwards). Note that the line patched out has no effect
> anymore either way, there is no sshkey resource with the associated tag
anyway.

OK, LGTM then.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5