Issue 4698 - Popup window is broken in Edge

stats.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 78 matching lines @@
   
   function onUnload()
   {
     FilterNotifier.off("filter.hitCount", updateStats);
   }
   
   function updateStats()
   {
     var statsPage = document.getElementById("stats-page");
     var blockedPage = getBlockedPerPage(currentPage).toLocaleString();
-    i18n.setElementText(statsPage, "stats_label_page", [blockedPage]);
+    i18n.setElementText(statsPage, "stats_label_page", blockedPage);

[Oleksandr, 2016/12/05 00:27:36]

Edge throws if passed an array as a second parameter to i18n.getMessage. Since
passing a single element is supported in Chrome as well, this looks like a safe
workaround.

[kzar, 2016/12/05 12:22:52]

How come that throws, since according to the Mozilla docs[1] it's supported?
What's the exception that's thrown? (I wonder how you're supposed to translate a
string with multiple substitutions if passing an array of substitutions doesn't
work.)

If this is a bug in the Edge extension API then please could you file an issue
with them?

[1]
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/i18n/getMessage

     
     var statsTotal = document.getElementById("stats-total");
     var blockedTotal = Prefs.blocked_total.toLocaleString();
-    i18n.setElementText(statsTotal, "stats_label_total", [blockedTotal]);
+    i18n.setElementText(statsTotal, "stats_label_total", blockedTotal);
   }
   
   function share(ev)
   {
     // Easter Egg
     var blocked = Prefs.blocked_total;
     if (blocked <= 9000 || blocked >= 10000)
       blocked = blocked.toLocaleString();
     else
       blocked = i18n.getMessage("stats_over", (9000).toLocaleString());
     
     ext.pages.open(createShareLink(ev.target.dataset.social, blocked));
   }
   
   function toggleIconNumber()
   {
     Prefs.show_statsinicon = !Prefs.show_statsinicon;
     document.getElementById("show-iconnumber").setAttribute("aria-checked", Prefs.show_statsinicon);
   }
   
   document.addEventListener("DOMContentLoaded", onLoad, false);
   window.addEventListener("unload", onUnload, false);
 })();