Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(101)

Issue 29366882: Issue 3574 - Refactor Puppet class base into class adblockplus (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by f.lopez
Modified:
2 years, 11 months ago
Reviewers:
mathias
CC:
f.nicolaisen, Fred
Visibility:
Public.

Description

Issue 3574 - Refactor Puppet class base into class adblockplus

Patch Set 1 #

Total comments: 4

Patch Set 2 : For comments 2 and 3 #

Total comments: 1

Patch Set 3 : For comment 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -100 lines) Patch
M Vagrantfile View 1 chunk +3 lines, -2 lines 0 comments Download
M hiera/puppet_node_classifier.rb View 1 chunk +1 line, -1 line 0 comments Download
M modules/adblockplus/manifests/init.pp View 1 2 chunks +1 line, -7 lines 0 comments Download
R modules/base/manifests/init.pp View 1 chunk +0 lines, -38 lines 0 comments Download
M modules/private-stub/hiera/hosts.yaml View 1 2 1 chunk +50 lines, -51 lines 0 comments Download
M modules/statsmaster/templates/sitescripts.ini.erb View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
f.lopez
2 years, 11 months ago (2016-12-06 10:40:32 UTC) #1
mathias
+1 https://codereview.adblockplus.org/29366882/diff/29366883/modules/private-stub/hiera/hosts.yaml File modules/private-stub/hiera/hosts.yaml (right): https://codereview.adblockplus.org/29366882/diff/29366883/modules/private-stub/hiera/hosts.yaml#newcode9 modules/private-stub/hiera/hosts.yaml:9: ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDkXTOj2JwvwlDaHbaMrDuosuRuU5ZuKe1EHNJa67ZxkB1a6Y1ObDxfYiYnvI5i9sQyUmmc5TrGAGGJs1BrriMaPayBaTSf3ymU2Rqxj3GZXuiioCxGV8I2R/aOhwvpbnVqZH5O99IuAZbrag5J/WhDWgWuk3gFrZxEwQmZW144tJH//I3b0oMAr3/arBViVeU52dHhKX9xdStTzFpWKUav/NoKKrgB91QKwPx8U6ymuDoCQU7qyTBnAX1sYuSwEMJzVRqtmKLybR4Xp5A94EMbJsgVbq4LrUrMo00FdLV0EGMmA2Kmd/9D+CuZXoD6/mWkzmaVfiUMKhrorM05voFp Please use quotes around the public ...
2 years, 11 months ago (2016-12-06 10:46:55 UTC) #2
mathias
https://codereview.adblockplus.org/29366882/diff/29366883/modules/adblockplus/manifests/init.pp File modules/adblockplus/manifests/init.pp (right): https://codereview.adblockplus.org/29366882/diff/29366883/modules/adblockplus/manifests/init.pp#newcode11 modules/adblockplus/manifests/init.pp:11: # similar to the deprecated and soon to be ...
2 years, 11 months ago (2016-12-06 10:52:55 UTC) #3
f.lopez
https://codereview.adblockplus.org/29366882/diff/29366883/modules/adblockplus/manifests/init.pp File modules/adblockplus/manifests/init.pp (right): https://codereview.adblockplus.org/29366882/diff/29366883/modules/adblockplus/manifests/init.pp#newcode11 modules/adblockplus/manifests/init.pp:11: # similar to the deprecated and soon to be ...
2 years, 11 months ago (2016-12-06 11:34:42 UTC) #4
f.lopez
2 years, 11 months ago (2016-12-06 11:36:40 UTC) #5
mathias
https://codereview.adblockplus.org/29366882/diff/29366938/modules/private-stub/hiera/hosts.yaml File modules/private-stub/hiera/hosts.yaml (right): https://codereview.adblockplus.org/29366882/diff/29366938/modules/private-stub/hiera/hosts.yaml#newcode9 modules/private-stub/hiera/hosts.yaml:9: 'ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDkXTOj2JwvwlDaHbaMrDuosuRuU5ZuKe1EHNJa67ZxkB1a6Y1ObDxfYiYnvI5i9sQyUmmc5TrGAGGJs1BrriMaPayBaTSf3ymU2Rqxj3GZXuiioCxGV8I2R/aOhwvpbnVqZH5O99IuAZbrag5J/WhDWgWuk3gFrZxEwQmZW144tJH//I3b0oMAr3/arBViVeU52dHhKX9xdStTzFpWKUav/NoKKrgB91QKwPx8U6ymuDoCQU7qyTBnAX1sYuSwEMJzVRqtmKLybR4Xp5A94EMbJsgVbq4LrUrMo00FdLV0EGMmA2Kmd/9D+CuZXoD6/mWkzmaVfiUMKhrorM05voFp' Double quotes please ;)
2 years, 11 months ago (2016-12-06 11:39:22 UTC) #6
f.lopez
2 years, 11 months ago (2016-12-06 11:42:38 UTC) #7
mathias
2 years, 11 months ago (2016-12-06 11:43:04 UTC) #8
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5