Issue 3574 - Refactor Puppet class base into class adblockplus

modules/adblockplus/manifests/init.pp

 # == Class: adblockplus
 #
 # The adblockplus class and the associated adblockplus:: namespace are
 # used to integrate Puppet modules with each other, in order to assemble
 # the setups used by the Adblock Plus project.
 #
 # === Parameters:
 #
 # [*authority*]
 #   The authorative domain or zone associated with the current environment,
 #   similar to the deprecated and soon to be removed $base::zone.

[mathias, 2016/12/06 10:52:55]

This line can be removed now.

[f.lopez, 2016/12/06 11:34:42]

Acknowledged.

 #
 # [*hosts*]
 #   A hash of adblockplus::host $name => $parameter items to set up in this
 #   context, i.e. via Hiera.
 #
 # [*users*]
 #   A hash of adblockplus::user $name => $parameter items to set up in this
 #   context, i.e. via Hiera.
 #
 # === Examples:
@@ skipping 15 matching lines @@
   $authority = hiera('adblockplus::authority', 'adblockplus.org'),
   $hosts = hiera_hash('adblockplus::hosts', {}),
   $packages = hiera_array('adblockplus::packages', []),
   $users = hiera_hash('adblockplus::users', {}),
 ) {
 
   include postfix
   include ssh
   include stdlib
 
-  # See https://issues.adblockplus.org/ticket/3574#comment:8
-  class {'base':
-    zone => $authority,
-  }
-
   # See https://issues.adblockplus.org/ticket/3575#comment:2
   class {'logrotate':
     stage => 'runtime',
   }
 
   # Class['apt'] cannot yet be configured to update on-demand
   class {'apt':
     always_apt_update => ($environment != 'development'),
   }
 
@@ skipping 56 matching lines @@
     ensure => 'present',
     mode => 0644,
   })
 
   # See modules/adblockplus/manifests/host.pp
   create_resources('adblockplus::host', $hosts)
 
   # See modules/adblockplus/manifests/user.pp
   create_resources('adblockplus::user', $users)
 }