Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29366966: [adblockpluscore] Issue 3672 - Moved antiadblockInit.js from adblockpluscore to adblockplusui (Closed)

Created:
Dec. 7, 2016, 7:47 a.m. by wspee
Modified:
Dec. 22, 2016, 8:47 a.m.
CC:
Felix Dahlke, Thomas Greiner
Visibility:
Public.

Description

Issue 3672 - Moved antiadblockInit.js from adblockpluscore to adblockplusui

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -90 lines) Patch
D lib/antiadblockInit.js View 1 chunk +0 lines, -90 lines 1 comment Download

Messages

Total messages: 12
wspee
See also https://codereview.adblockplus.org/29366969/
Dec. 7, 2016, 7:55 a.m. (2016-12-07 07:55:39 UTC) #1
kzar
(Setting Wladimir as the reviewer since he is the module owner for Core[1] which the ...
Dec. 7, 2016, 11:26 a.m. (2016-12-07 11:26:10 UTC) #2
Wladimir Palant
LGTM Please add some basic integration notes to the description in https://issues.adblockplus.org/ticket/3672 however - repositories ...
Dec. 7, 2016, 12:22 p.m. (2016-12-07 12:22:07 UTC) #3
wspee
On 2016/12/07 11:26:10, kzar wrote: > When submitting reviews where it is ambiguous which repository ...
Dec. 7, 2016, 1:55 p.m. (2016-12-07 13:55:34 UTC) #4
wspee
On 2016/12/07 12:22:07, Wladimir Palant wrote: > LGTM > > Please add some basic integration ...
Dec. 7, 2016, 1:58 p.m. (2016-12-07 13:58:56 UTC) #5
kzar
On 2016/12/07 13:55:34, wspee wrote: > I have prepared commits to change the metadata files, ...
Dec. 7, 2016, 2:20 p.m. (2016-12-07 14:20:42 UTC) #6
wspee
On 2016/12/07 14:20:42, kzar wrote: > Fair enough. (Sometimes I even upload the review with ...
Dec. 7, 2016, 2:33 p.m. (2016-12-07 14:33:42 UTC) #7
kzar
On 2016/12/07 14:20:42, kzar wrote: > Yep, it's issue #4569 which is blocking #4715. You ...
Dec. 7, 2016, 2:37 p.m. (2016-12-07 14:37:01 UTC) #8
wspee
On 2016/12/07 14:37:01, kzar wrote: > Damn I typed the issue number wrong, it's actually ...
Dec. 7, 2016, 2:49 p.m. (2016-12-07 14:49:53 UTC) #9
Sebastian Noack
https://codereview.adblockplus.org/29366966/diff/29366967/lib/antiadblockInit.js File lib/antiadblockInit.js (left): https://codereview.adblockplus.org/29366966/diff/29366967/lib/antiadblockInit.js#oldcode33 lib/antiadblockInit.js:33: title: Utils.getString("notification_antiadblock_title"), I suppose those translations should be removed ...
Dec. 13, 2016, 11:45 a.m. (2016-12-13 11:45:26 UTC) #10
wspee
On 2016/12/13 11:45:26, Sebastian Noack wrote: > I suppose those translations should be removed from ...
Dec. 19, 2016, 3:54 p.m. (2016-12-19 15:54:19 UTC) #11
Sebastian Noack
Dec. 21, 2016, 1:08 p.m. (2016-12-21 13:08:47 UTC) #12
LGTM

Powered by Google App Engine
This is Rietveld