lib/filterComposer.js - Issue 29366990: Issue 4714 - "Block element" context menu item fails to open window

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/filterComposer.js

Issue 29366990: Issue 4714 - "Block element" context menu item fails to open window (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome

Patch Set: Created Dec. 7, 2016, 12:56 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/filterComposer.js

===================================================================

--- a/lib/filterComposer.js

+++ b/lib/filterComposer.js

@@ -194,17 +194,16 @@ port.on("composer.openDialog", (message,

return new Promise(resolve =>

{

ext.windows.create({

url: ext.getURL("composer.html"),

left: 50,

top: 50,

width: 420,

height: 200,

- focused: true,

type: "popup"

popupPage =>

{

let popupPageId = popupPage.id;

function onRemoved(removedPageId)

{

if (popupPageId == removedPageId)

« no previous file with comments | « no previous file | no next file » | no next file with comments »