templates/default.tmpl - Issue 29366993: Issue 4629 - Default website boilerplate

Side by Side Diff: templates/default.tmpl

Issue 29366993: Issue 4629 - Default website boilerplate (Closed)

Patch Set: Created Dec. 7, 2016, 1:28 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <!--

	3 This file is part of website-boilerplate

	4 Copyright (C) 2016 Eyeo GmbH

	5

	6 website-boilerplate is free software: you can redistribute it and/or
	saroyanm 2017/01/11 12:04:41 Should we use our general license header we use in Should we use our general license header we use in website projects, while this is going to be a starting point for our websites ? juliandoucette 2017/03/03 11:17:43 I don't understand the question. If this boilerpla Show quoted text On 2017/01/11 12:04:41, saroyanm wrote: > Should we use our general license header we use in website projects, while this > is going to be a starting point for our websites ? I don't understand the question. If this boilerplate belongs to it's own repository, it is it's own project, and needs it's own project name inside it's licence header.
	7 modify it under the terms of the GNU General Public License as published by

	8 the Free Software Foundation, either version 3 of the License, or

	9 (at your option) any later version.

	10

	11 website-boilerplate is distributed in the hope that it will be useful,

	12 but WITHOUT ANY WARRANTY; without even the implied warranty of

	13 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

	14 GNU General Public License for more details.

	15

	16 You should have received a copy of the GNU General Public License

	17 along with website-boilerplate. If not, see <http://www.gnu.org/licenses/>.

	18 -->

	19 <html lang="{{ locale }}" dir="{{ "rtl" if config.has_option("rtl", locale) else "ltr" }}">

	20 <head>

	21 <meta charset="utf-8">

	22 <meta name="viewport" content="width=device-width, initial-scale=1, shrink-t o-fit=no">

	23 <meta http-equiv="x-ua-compatible" content="ie=edge">

	24 <title>{{ title \| translate("document-title", "Document title") }}</title>

	25 <meta name="description" content="{{ description \| translate("document-descr iption", "Document description") }}">

	26 <meta property="og:site_name" content="{{ site.fb_site_name }}">

	27 <meta property="og:image" content="{{ fb_image if fb_image else site.fb_imag e }}">

	28 <meta proprety="og:url" content="{{ site.url }}/{{ locale }}/{{ page }}">

	29 <meta property="og:locale" content="{{ locale }}">

	30 <meta property="og:locale:alternative" content="{{ locales }}">
	saroyanm 2017/01/11 12:04:41 The way I understand the "og:locale:alternative" t The way I understand the "og:locale:alternative" that it lists all other languages that the page is available in, but here seems like we are just duplicating same locale. juliandoucette 2017/03/03 11:17:43 IDK if this was recently changed, but it looks lik Show quoted text On 2017/01/11 12:04:41, saroyanm wrote: > The way I understand the "og:locale:alternative" that it lists all other > languages that the page is available in, but here seems like we are just > duplicating same locale. IDK if this was recently changed, but it looks like we should create an og:locale:alternate for each alternative languange. Not one og:locale:alternative list of languages.
	31 <meta name="twitter:site" content="{{ site.twitter_handle }}">
	saroyanm 2017/01/11 12:04:40 What about using other twitter cards ? We can use What about using other twitter cards ? We can use same title/description/image we specified above. juliandoucette 2017/03/03 11:17:44 I think that the default card type is OK. And we c Show quoted text On 2017/01/11 12:04:40, saroyanm wrote: > What about using other twitter cards ? We can use same title/description/image > we specified above. I think that the default card type is OK. And we can override it by adding to the head block in pages. The twitter:site refers to the twitter handle (username) of the site though.
	32 <link rel="canonical" href="{{ site.url }}/{{ page }}">

	33 <link rel="apple-touch-icon" sizes="180x180" href="/img/apple-touch-icon.png ">
	saroyanm 2017/01/11 12:04:40 I think it make sense to use placeholders for the I think it make sense to use placeholders for the missing images. juliandoucette 2017/03/03 11:17:44 I just excluded images from this review. Show quoted text On 2017/01/11 12:04:40, saroyanm wrote: > I think it make sense to use placeholders for the missing images. I just excluded images from this review.
	34 <link rel="icon" type="image/png" href="/img/favicon-32x32.png" sizes="32x32 ">

	35 <link rel="icon" type="image/png" href="/img/favicon-16x16.png" sizes="16x16 ">

	36 <link rel="manifest" href="/json/manifest.json">
	saroyanm 2017/01/11 12:04:40 I think this only useful for web apps, also i can' I think this only useful for web apps, also i can't see manifest.json included. juliandoucette 2017/03/03 11:17:43 Acknowledged. The manifest is also used to specif Show quoted text On 2017/01/11 12:04:40, saroyanm wrote: > I think this only useful for web apps, also i can't see manifest.json included. Acknowledged. The manifest is also used to specify tile images (favicons).
	37 <link rel="mask-icon" href="/img/safari-pinned-tab.svg" color="#777777">

	38 <meta name="theme-color" content="#ffffff">
	saroyanm 2017/01/11 12:04:40 Detail: let's keep meta tags together, I suggest r Detail: let's keep meta tags together, I suggest rearrange them. juliandoucette 2017/03/03 11:17:44 Acknowledged. I have no strong opinion. This is g Show quoted text On 2017/01/11 12:04:40, saroyanm wrote: > Detail: let's keep meta tags together, I suggest rearrange them. Acknowledged. I have no strong opinion. This is grouped with the others because it relates to the favicon. The theme-color is used to define the background color of the favicon.
	39 <!--[if IE 8]>

	40 <script src="/js/vendor/ie8.js"></script>

	41 <![endif]-->

	42 <link rel="stylesheet" href="/css/main.css">
	saroyanm 2017/01/11 12:04:41 Is there a particular reason why you have put the Is there a particular reason why you have put the main.css in the middle of IE scripts ? juliandoucette 2017/03/03 11:17:44 Acknowledged. IDK. I will move it above IE8 condi Show quoted text On 2017/01/11 12:04:41, saroyanm wrote: > Is there a particular reason why you have put the main.css in the middle of IE > scripts ? Acknowledged. IDK. I will move it above IE8 condition.
	43 {% block head %}

	44 {{ head \| safe }}

	45 {% endblock %}

	46 <!--[if lt IE 9]>

	47 <script src="/js/vendor/html5shiv.js"></script>

	48 <script src="/js/vendor/respond.min.js"></script>

	49 <![endif]-->

	50 </head>

	51 <body>

	52 <div class="container">

	53 <header id="header">
	ire 2017/06/22 16:14:24 I don't think this (or the main or footer) should I don't think this (or the main or footer) should have an ID as a default. And particularly a generic id like "header" juliandoucette 2017/06/22 18:23:52 Acknowledged. Show quoted text On 2017/06/22 16:14:24, ire wrote: > I don't think this (or the main or footer) should have an ID as a default. And > particularly a generic id like "header" Acknowledged.
	54 <h1>{{ title \| translate("document-title") }}</h1>

	55 <p>{{ description \| translate("document-description") }}</p>

	56 </header>

	57 <main id="main">

	58 {% block body %}

	59 {{ body \| safe }}

	60 {% endblock %}

	61 </main>

	62 <footer id="footer">

	63 <!-- sitemap -->
	saroyanm 2017/01/11 12:04:41 detail: It's a footer content, not sitemap. detail: It's a footer content, not sitemap. juliandoucette 2017/03/03 11:17:44 Acknowledged. I had originally planned to impleme Show quoted text On 2017/01/11 12:04:41, saroyanm wrote: > detail: It's a footer content, not sitemap. Acknowledged. I had originally planned to implement a simple sitemap in the footer. I will remove this.
	64 </footer>

	65 </div>

	66 </body>

	67 </html>

OLD	NEW

« static/scss/main.scss ('K') | « static/scss/main.scss ('k') | no next file » | no next file with comments »