Unified Diff: templates/default.tmpl
Issue 29366993:
Issue 4629 - Default website boilerplate (Closed)
Patch Set:
Created Dec. 7, 2016, 1:28 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« static/scss/main.scss ('K')
|
« static/scss/main.scss ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: templates/default.tmpl |
| =================================================================== |
| new file mode 100755 |
| --- /dev/null |
| +++ b/templates/default.tmpl |
| @@ -0,0 +1,67 @@ |
| +<!DOCTYPE html> |
| +<!-- |
| + This file is part of website-boilerplate |
| + Copyright (C) 2016 Eyeo GmbH |
| + |
| + website-boilerplate is free software: you can redistribute it and/or |
|
saroyanm
2017/01/11 12:04:41
Should we use our general license header we use in
juliandoucette
2017/03/03 11:17:43
I don't understand the question. If this boilerpla
|
| + modify it under the terms of the GNU General Public License as published by |
| + the Free Software Foundation, either version 3 of the License, or |
| + (at your option) any later version. |
| + |
| + website-boilerplate is distributed in the hope that it will be useful, |
| + but WITHOUT ANY WARRANTY; without even the implied warranty of |
| + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| + GNU General Public License for more details. |
| + |
| + You should have received a copy of the GNU General Public License |
| + along with website-boilerplate. If not, see <http://www.gnu.org/licenses/>. |
| +--> |
| +<html lang="{{ locale }}" dir="{{ "rtl" if config.has_option("rtl", locale) else "ltr" }}"> |
| + <head> |
| + <meta charset="utf-8"> |
| + <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no"> |
| + <meta http-equiv="x-ua-compatible" content="ie=edge"> |
| + <title>{{ title | translate("document-title", "Document title") }}</title> |
| + <meta name="description" content="{{ description | translate("document-description", "Document description") }}"> |
| + <meta property="og:site_name" content="{{ site.fb_site_name }}"> |
| + <meta property="og:image" content="{{ fb_image if fb_image else site.fb_image }}"> |
| + <meta proprety="og:url" content="{{ site.url }}/{{ locale }}/{{ page }}"> |
| + <meta property="og:locale" content="{{ locale }}"> |
| + <meta property="og:locale:alternative" content="{{ locales }}"> |
|
saroyanm
2017/01/11 12:04:41
The way I understand the "og:locale:alternative" t
juliandoucette
2017/03/03 11:17:43
IDK if this was recently changed, but it looks lik
|
| + <meta name="twitter:site" content="{{ site.twitter_handle }}"> |
|
saroyanm
2017/01/11 12:04:40
What about using other twitter cards ? We can use
juliandoucette
2017/03/03 11:17:44
I think that the default card type is OK. And we c
|
| + <link rel="canonical" href="{{ site.url }}/{{ page }}"> |
| + <link rel="apple-touch-icon" sizes="180x180" href="/img/apple-touch-icon.png"> |
|
saroyanm
2017/01/11 12:04:40
I think it make sense to use placeholders for the
juliandoucette
2017/03/03 11:17:44
I just excluded images from this review.
|
| + <link rel="icon" type="image/png" href="/img/favicon-32x32.png" sizes="32x32"> |
| + <link rel="icon" type="image/png" href="/img/favicon-16x16.png" sizes="16x16"> |
| + <link rel="manifest" href="/json/manifest.json"> |
|
saroyanm
2017/01/11 12:04:40
I think this only useful for web apps, also i can'
juliandoucette
2017/03/03 11:17:43
Acknowledged.
The manifest is also used to specif
|
| + <link rel="mask-icon" href="/img/safari-pinned-tab.svg" color="#777777"> |
| + <meta name="theme-color" content="#ffffff"> |
|
saroyanm
2017/01/11 12:04:40
Detail: let's keep meta tags together, I suggest r
juliandoucette
2017/03/03 11:17:44
Acknowledged.
I have no strong opinion. This is g
|
| + <!--[if IE 8]> |
| + <script src="/js/vendor/ie8.js"></script> |
| + <![endif]--> |
| + <link rel="stylesheet" href="/css/main.css"> |
|
saroyanm
2017/01/11 12:04:41
Is there a particular reason why you have put the
juliandoucette
2017/03/03 11:17:44
Acknowledged.
IDK. I will move it above IE8 condi
|
| + {% block head %} |
| + {{ head | safe }} |
| + {% endblock %} |
| + <!--[if lt IE 9]> |
| + <script src="/js/vendor/html5shiv.js"></script> |
| + <script src="/js/vendor/respond.min.js"></script> |
| + <![endif]--> |
| + </head> |
| + <body> |
| + <div class="container"> |
| + <header id="header"> |
|
ire
2017/06/22 16:14:24
I don't think this (or the main or footer) should
juliandoucette
2017/06/22 18:23:52
Acknowledged.
|
| + <h1>{{ title | translate("document-title") }}</h1> |
| + <p>{{ description | translate("document-description") }}</p> |
| + </header> |
| + <main id="main"> |
| + {% block body %} |
| + {{ body | safe }} |
| + {% endblock %} |
| + </main> |
| + <footer id="footer"> |
| + <!-- sitemap --> |
|
saroyanm
2017/01/11 12:04:41
detail: It's a footer content, not sitemap.
juliandoucette
2017/03/03 11:17:44
Acknowledged.
I had originally planned to impleme
|
| + </footer> |
| + </div> |
| + </body> |
| +</html> |
« static/scss/main.scss ('K')
|
« static/scss/main.scss ('k')
|
no next file »
|
no next file with comments »
