Issue #4711 - Rewrite legacy thread facilities

src/Scheduler.cpp

+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-2016 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include "Scheduler.h"
+#include <thread>
+using namespace AdblockPlus;
+
+namespace
+{
+  void SingleUseThreadMain(std::function<void()> task)
+  {
+    task();
+  }
+}
+
+void Scheduler::StartImmediatelyInSingleUseThread(std::function<void()> task)
+{
+  if (!task)
+  {
+    return;
+  }
+  auto th = std::thread(SingleUseThreadMain, task);

[sergei, 2017/01/16 14:50:13]

SingleUseThreadMain is definitely redundant in this commit.

[Eric, 2017/01/16 15:20:16]

In this commit, yes. It grows in later change sets.
StartImmediatelyInSingleUseThread is eliminated entirely a few changes hence.

If this were a final change it would be worth fixing.

[hub, 2017/05/12 14:45:39]

With the other suggestion with task that is a unique_ptr<T>, you could just do 

// can't capture a unique_ptr<> in a lambda
std::shared_ptr<T> pt(std::move(task));
auto th = std::thread([pt]() { (*pt)(); });

+  th.detach();
+}