metadata.edge - Issue 29367151: Issue 4721 - Use IndexedDB for storage in Edge

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.edge

Issue 29367151: Issue 4721 - Use IndexedDB for storage in Edge (Closed)

Left Patch Set: Created Dec. 9, 2016, 6:38 a.m.

Right Patch Set: Use arrow functions. Remove code duplication. Address comments and nits. Created Dec. 13, 2016, 6:16 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [default]	1 [default]

2 inherit = metadata.common	2 inherit = metadata.chrome

3	3

4 [general]	4 [general]

5 basename = adblockplusedge	5 basename = adblockplusedge

6 app_id = EyeoGmbH.AdblockPlus	6 app_id = EyeoGmbH.AdblockPlus

7 publisher_id = CN=4F066043-8AFE-41C9-B762-6C15E77E3F88	7 publisher_id = CN=4F066043-8AFE-41C9-B762-6C15E77E3F88

8 permissions = tabs

9 http:///

10 https:///

11 contextMenus

12 webRequest

13 webRequestBlocking

14 webNavigation

15 storage

16 unlimitedStorage

17 notifications

18 options = options.html

19 background_color = red	8 background_color = red

20 browserAction = icons/abp-16.png icons/abp-19.png icons/abp-20.png icons/abp-32. png icons/abp-38.png icons/abp-40.png popup.html

21 icons = icons/abp-16.png icons/abp-32.png icons/detailed/abp-48.png

22 icons/detailed/abp-64.png icons/detailed/abp-128.png

23	9

24 [compat]	10 [compat]

25 edge = 37.14332.1000.0	11 edge = 37.14332.1000.0

26 windows = 10.0.14332.0/12.0.0.0	12 windows = 10.0.14332.0/12.0.0.0

27

28 [mapping]

29 icons/abp-16.png = chrome/icons/abp-16.png

30 icons/abp-16-whitelisted.png = chrome/icons/abp-16-whitelisted.png

31 icons/abp-16-notification-critical.png = chrome/icons/abp-16-notification-critic al.png

32 icons/abp-16-notification-information.png = chrome/icons/abp-16-notification-inf ormation.png

33 icons/abp-19.png = chrome/icons/abp-19.png

34 icons/abp-19-whitelisted.png = chrome/icons/abp-19-whitelisted.png

35 icons/abp-19-notification-critical.png = chrome/icons/abp-19-notification-critic al.png

36 icons/abp-19-notification-information.png = chrome/icons/abp-19-notification-inf ormation.png

37 icons/abp-20.png = chrome/icons/abp-20.png

38 icons/abp-20-whitelisted.png = chrome/icons/abp-20-whitelisted.png

39 icons/abp-20-notification-critical.png = chrome/icons/abp-20-notification-critic al.png

40 icons/abp-20-notification-information.png = chrome/icons/abp-20-notification-inf ormation.png

41 icons/abp-32.png = chrome/icons/abp-32.png

42 icons/abp-32-whitelisted.png = chrome/icons/abp-32-whitelisted.png

43 icons/abp-32-notification-critical.png = chrome/icons/abp-32-notification-critic al.png

44 icons/abp-32-notification-information.png = chrome/icons/abp-32-notification-inf ormation.png

45 icons/abp-38.png = chrome/icons/abp-38.png

46 icons/abp-38-whitelisted.png = chrome/icons/abp-38-whitelisted.png

47 icons/abp-38-notification-critical.png = chrome/icons/abp-38-notification-critic al.png

48 icons/abp-38-notification-information.png = chrome/icons/abp-38-notification-inf ormation.png

49 icons/abp-40.png = chrome/icons/abp-40.png

50 icons/abp-40-whitelisted.png = chrome/icons/abp-40-whitelisted.png

51 icons/abp-40-notification-critical.png = chrome/icons/abp-40-notification-critic al.png

52 icons/abp-40-notification-information.png = chrome/icons/abp-40-notification-inf ormation.png

53 icons/detailed/abp-48.png = chrome/icons/detailed/abp-48.png

54	13

55 [appx_assets]	14 [appx_assets]

56 logo_44.png = icons/abp-44.png	15 logo_44.png = icons/abp-44.png

57 logo_50.png = icons/abp-50.png	16 logo_50.png = icons/abp-50.png

58 logo_150.png = icons/abp-150.png	17 logo_150.png = icons/abp-150.png

59	18

60 [convert_js]	19 [convert_js]

61 lib/adblockplus.js += lib/popupBlocker.js lib/uninstall.js lib/csp.js	20 ext/background.js += edge/localforage.min.js edge/ext/background.js

62 ext/common.js += chrome/ext/common.js

63 ext/background.js += chrome/ext/background.js edge/localforage.min.js edge/ext/b ackground.js

LEFT	RIGHT