Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29367157: Issue 4680 - Fixed regression with showOptions callback (Closed)

Created:
Dec. 9, 2016, 10:04 a.m. by kzar
Modified:
Jan. 12, 2017, 7:42 a.m.
Reviewers:
Sebastian Noack
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 4680 - Fixed regression with showOptions callback

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M chrome/ext/background.js View 1 chunk +26 lines, -1 line 1 comment Download
M lib/notificationHelper.js View 1 chunk +1 line, -0 lines 1 comment () Download

Messages

Total messages: 2
kzar
Patch Set 1 Tested by running this in the background console: require("notification").Notification.addNotification({ id: new Date() ...
Dec. 9, 2016, 10:08 a.m. (2016-12-09 10:08:21 UTC) #1
Sebastian Noack
Jan. 11, 2017, 6:25 p.m. (2017-01-11 18:25:30 UTC) #2
That should be good enough for now, LGTM. I really hope that we get rid of that
crappy abstraction soon, in favor of using the browserext API.

Powered by Google App Engine
This is Rietveld