Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29367169: Issues 4521 - Added social media buttons on eyeo contactpage (Closed)

Created:
Dec. 9, 2016, 3:35 p.m. by erick
Modified:
Jan. 31, 2017, 3:39 p.m.
Reviewers:
saroyanm
CC:
juliandoucette
Visibility:
Public.

Description

Issues 4521 - Added social media buttons on eyeo contactpage

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed old twitter logo and optimized pngs #

Total comments: 1

Patch Set 3 : Changed image names to more consistent text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M includes/contact/details.md View 1 2 1 chunk +4 lines, -1 line 0 comments Download
A static/images/eyeo-facebook.png View 1 Binary file 0 comments Download
A static/images/eyeo-instagram.png View 1 Binary file 0 comments Download
A static/images/eyeo-linkedin.png View 1 Binary file 0 comments Download
A static/images/eyeo-twitter.png View 1 Binary file 0 comments Download
D static/images/twitter.png View 1 Binary file 0 comments Download

Messages

Total messages: 6
erick
Dec. 9, 2016, 3:43 p.m. (2016-12-09 15:43:21 UTC) #1
saroyanm
https://codereview.adblockplus.org/29367169/diff/29367170/includes/contact/details.md File includes/contact/details.md (right): https://codereview.adblockplus.org/29367169/diff/29367170/includes/contact/details.md#newcode3 includes/contact/details.md:3: [![Twitter](/images/eyeo-twitter.png)](https://twitter.com/eyeo) What about old twitter Image ? Did you ...
Dec. 14, 2016, 3:06 p.m. (2016-12-14 15:06:23 UTC) #2
erick
On 2016/12/14 15:06:23, saroyanm wrote: > https://codereview.adblockplus.org/29367169/diff/29367170/includes/contact/details.md > File includes/contact/details.md (right): > > https://codereview.adblockplus.org/29367169/diff/29367170/includes/contact/details.md#newcode3 > ...
Dec. 15, 2016, 11:54 a.m. (2016-12-15 11:54:23 UTC) #3
saroyanm
https://codereview.adblockplus.org/29367169/diff/29368553/includes/contact/details.md File includes/contact/details.md (right): https://codereview.adblockplus.org/29367169/diff/29368553/includes/contact/details.md#newcode4 includes/contact/details.md:4: [![Twitter](/images/eyeo-facebook.png)](https://www.facebook.com/EyeoGmbH) Please use consistent alternative text for each image ...
Dec. 15, 2016, 2:25 p.m. (2016-12-15 14:25:18 UTC) #4
erick
Changed image names to more consistent text
Dec. 16, 2016, 8:51 a.m. (2016-12-16 08:51:22 UTC) #5
saroyanm
Dec. 19, 2016, 4:47 p.m. (2016-12-19 16:47:55 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld