chrome/content/elemHideEmulation.js - Issue 29367181: Issue 4726 - Add tests for the element hiding emulation content script

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: chrome/content/elemHideEmulation.js

Issue 29367181: Issue 4726 - Add tests for the element hiding emulation content script (Closed) Base URL: https://bitbucket.org/fhd/adblockpluscore

Patch Set: Addressed remaining comments Created Jan. 17, 2017, 7:39 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
	1 // We are currently limited to ECMAScript 5 in this file, because it is being
	kzar 2017/01/18 04:17:15 Perhaps mentioning PhantomJS and the version in th Perhaps mentioning PhantomJS and the version in these comments would be useful? "We are currently limited to ECMAScript 5 in this file since the browser tests are run using PhantomJS 2.17. See https://issues.adblockplus.org/ticket/4796" Felix Dahlke 2017/01/19 09:56:51 The information is in the issue, I'd personally ra Show quoted text On 2017/01/18 04:17:15, kzar wrote: > Perhaps mentioning PhantomJS and the version in these comments would be useful? > > "We are currently limited to ECMAScript 5 in this file since the browser tests > are run using PhantomJS 2.17. See > https://issues.adblockplus.org/ticket/4796%22 The information is in the issue, I'd personally rather not duplicate (or rather "quadruplicate") it.
	2 // used in the browser tests. See https://issues.adblockplus.org/ticket/4796

	3

1 var propertySelectorRegExp = /\[\-abp\-properties=(["'])([^"']+)\1\]/;	4 var propertySelectorRegExp = /\[\-abp\-properties=(["'])([^"']+)\1\]/;

2	5

3 function splitSelector(selector)	6 function splitSelector(selector)

4 {	7 {

5 if (selector.indexOf(",") == -1)	8 if (selector.indexOf(",") == -1)

6 return [selector];	9 return [selector];

7	10

8 var selectors = [];	11 var selectors = [];

9 var start = 0;	12 var start = 0;

10 var level = 0;	13 var level = 0;

(...skipping 146 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
157 apply: function()	160 apply: function()

158 {	161 {

159 if (this.patterns.length > 0)	162 if (this.patterns.length > 0)

160 {	163 {

161 var document = this.window.document;	164 var document = this.window.document;

162 this.addSelectors(document.styleSheets);	165 this.addSelectors(document.styleSheets);

163 document.addEventListener("load", this.onLoad.bind(this), true);	166 document.addEventListener("load", this.onLoad.bind(this), true);

164 }	167 }

165 }	168 }

166 };	169 };

OLD	NEW

« no previous file with comments | « README.md ('k') | lib/common.js » ('j') | test/browser/elemHideEmulation.js » ('J')