Issue 4726 - Add tests for the element hiding emulation content script

test/browser/elemHideEmulation.js

+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-2017 Eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+// We are currently limited to ECMAScript 5 in this file, because it is being
+// used in the browser tests. See https://issues.adblockplus.org/ticket/4796
+
 QUnit.module("Element hiding emulation",
 {
   before: function()
   {
     // The URL object in PhantomJS 2.1.7 does not implement any properties, so
     // we need a polyfill.
     if (!URL || !("origin" in URL))
     {
       var doc = document.implementation.createHTMLDocument();
       var anchor = doc.createElement("a");
@@ skipping 33 matching lines @@
   if (!document.getElementById(id))
     return id;
   return findUniqueId();
 }
 
 function insertStyleRule(rule)
 {
   var styleElement;
   var styleElements = document.head.getElementsByTagName("style");
   if (styleElements.length)
+  {
     styleElement = styleElements[0];
+  }
   else
   {
     styleElement = document.createElement("style");
     document.head.appendChild(styleElement);
   }
   styleElement.sheet.insertRule(rule, styleElement.sheet.cssRules.length);
 }
 
 function createElementWithStyle(styleBlock)
 {
@@ skipping 26 matching lines @@
     }
   );
 
   elemHideEmulation.load(function()
   {
     elemHideEmulation.apply();
     callback();
   });
 }
 
-QUnit.test("Verbatim property selector", function(assert)
-{
-  var done = assert.async();
-  var toHide = createElementWithStyle("{background-color: #000}");
-  applyElemHideEmulation(["[-abp-properties='background-color: rgb(0, 0, 0)']"],
-    function()

[Felix Dahlke, 2016/12/11 12:13:49]

Not so sure about this indentation style - suggestions welcome.

-  {
-    assert.hidden(toHide);
-    done();
-  });
-});
-
-QUnit.test("Property selector with wildcard", function(assert)
-{
-  var done = assert.async();
-  var toHide = createElementWithStyle("{background-color: #000}");
-  applyElemHideEmulation(["[-abp-properties='*color: rgb(0, 0, 0)']"],
-    function()
-  {
-    assert.hidden(toHide);
-    done();
-  });
-});
-
-QUnit.test("Property selector with regular expression", function(assert)
-{
-  var done = assert.async();
-  var toHide = createElementWithStyle("{background-color: #000}");
-  applyElemHideEmulation(["[-abp-properties='/.*color: rgb\\(0, 0, 0\\)/']"],
-    function()
-  {
-    assert.hidden(toHide);
-    done();
-  });
-});
-
-QUnit.test("Property selector works for dynamically changed property",
-  function(assert)
-{
-  var done = assert.async();
-  var toHide = createElementWithStyle("{}");
-  applyElemHideEmulation(["[-abp-properties='background-color: rgb(0, 0, 0)']"],
-    function()
-  {
-    assert.visible(toHide);
-    insertStyleRule("#" + toHide.id + " {background-color: #000}");
-    setTimeout(function()
-    {
-      assert.hidden(toHide);
-      done();
-    });
-  });
-});
+QUnit.test(
+  "Verbatim property selector",
+  function(assert)
+  {
+    var done = assert.async();
+    var toHide = createElementWithStyle("{background-color: #000}");
+    applyElemHideEmulation(
+      ["[-abp-properties='background-color: rgb(0, 0, 0)']"],
+      function()
+      {
+        assert.hidden(toHide);
+        done();
+      }
+    );
+  }
+);
+
+QUnit.test(
+  "Property selector with wildcard",
+  function(assert)
+  {
+    var done = assert.async();
+    var toHide = createElementWithStyle("{background-color: #000}");
+    applyElemHideEmulation(
+      ["[-abp-properties='*color: rgb(0, 0, 0)']"],
+      function()
+      {
+        assert.hidden(toHide);
+        done();
+      }
+    );
+  }
+);
+
+QUnit.test(
+  "Property selector with regular expression",
+  function(assert)
+  {
+    var done = assert.async();
+    var toHide = createElementWithStyle("{background-color: #000}");
+    applyElemHideEmulation(
+      ["[-abp-properties='/.*color: rgb\\(0, 0, 0\\)/']"],
+      function()
+      {
+        assert.hidden(toHide);
+        done();
+      }
+    );
+  }
+);
+
+QUnit.test(
+  "Property selector with regular expression containing escaped brace",
+  function(assert)
+  {
+    var done = assert.async();
+    var toHide = createElementWithStyle("{background-color: #000}");
+    applyElemHideEmulation(
+      ["[-abp-properties='/background.\\x7B 0,6\\x7D : rgb\\(0, 0, 0\\)/']"],
+      function()
+      {
+        assert.hidden(toHide);
+        done();
+      }
+    );
+  }
+);
+
+QUnit.test(
+  "Property selector with regular expression containing improperly escaped \
+brace",
+  function(assert)
+  {
+    var done = assert.async();
+    var toHide = createElementWithStyle("{background-color: #000}");
+    applyElemHideEmulation(
+      ["[-abp-properties='/background.\\x7B0,6\\x7D: rgb\\(0, 0, 0\\)/']"],
+      function()
+      {
+        assert.visible(toHide);
+        done();
+      }
+    );
+  }
+);
+
+QUnit.test(
+  "Property selector works for dynamically changed property",
+  function(assert)
+  {
+    var done = assert.async();
+    var toHide = createElementWithStyle("{}");
+    applyElemHideEmulation(
+      ["[-abp-properties='background-color: rgb(0, 0, 0)']"],
+      function()
+      {
+        assert.visible(toHide);
+        insertStyleRule("#" + toHide.id + " {background-color: #000}");
+        setTimeout(function()
+        {
+          assert.hidden(toHide);
+          done();
+        });
+      }
+    );
+  }
+);