Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29367268: Issue 4474 - short version of Privacy Policy at eyeo.com (Closed)

Created:
Dec. 12, 2016, 6:34 p.m. by juliandoucette
Modified:
Dec. 19, 2016, 3:32 p.m.
Reviewers:
j.nink, saroyanm
CC:
Lisa
Base URL:
https://hg.adblockplus.org/web.eyeo.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Undid minor text change. #

Total comments: 7

Patch Set 3 : Fixed unconverted markdown email link. #

Total comments: 37

Patch Set 4 : Separated duplicates, corrected 'eyeo', and updated date #

Patch Set 5 : Changed E case in address #

Total comments: 5

Patch Set 6 : Separated cookies in data collection list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -61 lines) Patch
A includes/address.html View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
A includes/privacy/data-collected.html View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
M pages/privacy.html View 1 2 3 4 5 1 chunk +167 lines, -61 lines 0 comments Download

Messages

Total messages: 19
juliandoucette
Dec. 12, 2016, 6:34 p.m. (2016-12-12 18:34:39 UTC) #1
juliandoucette
@Manvel this should be a quick one. @Judith please find questions below. https://codereview.adblockplus.org/29367268/diff/29367271/pages/privacy.html File pages/privacy.html ...
Dec. 12, 2016, 6:57 p.m. (2016-12-12 18:57:43 UTC) #2
j.nink
Looks very good to me. Thanks so much for speeding that up. Very much appreciated. ...
Dec. 13, 2016, 7:58 a.m. (2016-12-13 07:58:29 UTC) #3
saroyanm
Just small changes. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#newcode1 pages/privacy.html:1: title=Privacy Policy You converted the file ...
Dec. 13, 2016, 3:09 p.m. (2016-12-13 15:09:54 UTC) #4
saroyanm
https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#newcode102 pages/privacy.html:102: Your protection and data confidentiality is of utmost importance ...
Dec. 13, 2016, 3:11 p.m. (2016-12-13 15:11:47 UTC) #5
j.nink
https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#newcode20 pages/privacy.html:20: While using the Eyeo.com website: On 2016/12/13 15:09:54, saroyanm ...
Dec. 13, 2016, 3:18 p.m. (2016-12-13 15:18:21 UTC) #6
saroyanm
https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#newcode20 pages/privacy.html:20: While using the Eyeo.com website: On 2016/12/13 15:18:21, j.nink ...
Dec. 13, 2016, 3:27 p.m. (2016-12-13 15:27:35 UTC) #7
j.nink
https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#newcode110 pages/privacy.html:110: <address> On 2016/12/13 15:27:35, saroyanm wrote: > @Judith: What ...
Dec. 13, 2016, 3:29 p.m. (2016-12-13 15:29:59 UTC) #8
saroyanm
Added notes from the quick meeting with @Judith https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#newcode20 pages/privacy.html:20: While ...
Dec. 13, 2016, 3:57 p.m. (2016-12-13 15:57:43 UTC) #9
j.nink
https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#newcode20 pages/privacy.html:20: While using the Eyeo.com website: On 2016/12/13 15:57:43, saroyanm ...
Dec. 13, 2016, 3:59 p.m. (2016-12-13 15:59:22 UTC) #10
juliandoucette
Please find one question below @Judith (Should we change the date at the bottom to ...
Dec. 13, 2016, 4:41 p.m. (2016-12-13 16:41:10 UTC) #11
saroyanm
https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#newcode1 pages/privacy.html:1: title=Privacy Policy On 2016/12/13 16:41:09, juliandoucette wrote: > On ...
Dec. 13, 2016, 5:07 p.m. (2016-12-13 17:07:17 UTC) #12
j.nink
https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#newcode211 pages/privacy.html:211: <time datetime="2016-08">August 2016</time> On 2016/12/13 16:41:09, juliandoucette wrote: > ...
Dec. 13, 2016, 9:09 p.m. (2016-12-13 21:09:45 UTC) #13
juliandoucette
Thanks everyone! Sorry about the delay on this one. https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29367273/pages/privacy.html#newcode1 pages/privacy.html:1: ...
Dec. 19, 2016, 2:36 p.m. (2016-12-19 14:36:32 UTC) #14
saroyanm
https://codereview.adblockplus.org/29367268/diff/29369059/includes/address.html File includes/address.html (right): https://codereview.adblockplus.org/29367268/diff/29369059/includes/address.html#newcode1 includes/address.html:1: <address> We do include address also in the contacts ...
Dec. 19, 2016, 2:57 p.m. (2016-12-19 14:57:29 UTC) #15
j.nink
https://codereview.adblockplus.org/29367268/diff/29369059/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29369059/pages/privacy.html#newcode43 pages/privacy.html:43: <li>Data entered by user into the job application form ...
Dec. 19, 2016, 2:59 p.m. (2016-12-19 14:59:57 UTC) #16
saroyanm
https://codereview.adblockplus.org/29367268/diff/29369059/includes/address.html File includes/address.html (right): https://codereview.adblockplus.org/29367268/diff/29369059/includes/address.html#newcode1 includes/address.html:1: <address> On 2016/12/19 14:57:28, saroyanm wrote: > We do ...
Dec. 19, 2016, 3:24 p.m. (2016-12-19 15:24:05 UTC) #17
saroyanm
LGTM https://codereview.adblockplus.org/29367268/diff/29369059/pages/privacy.html File pages/privacy.html (right): https://codereview.adblockplus.org/29367268/diff/29369059/pages/privacy.html#newcode43 pages/privacy.html:43: <li>Data entered by user into the job application ...
Dec. 19, 2016, 3:25 p.m. (2016-12-19 15:25:21 UTC) #18
juliandoucette
Dec. 19, 2016, 3:32 p.m. (2016-12-19 15:32:48 UTC) #19

Powered by Google App Engine
This is Rietveld