Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/icon.js

Issue 29367316: Issue 4722 - Drop support for Chrome 41 - 48 (Closed)
Left Patch Set: Created Dec. 13, 2016, 10:54 a.m.
Right Patch Set: Addressed nit Created Dec. 16, 2016, 10:26 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « lib/csp.js ('k') | lib/polyfills/fetch.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 { 57 {
58 if (opacity > 0.5) 58 if (opacity > 0.5)
59 page.browserAction.setIcon("icons/abp-$size-notification-" 59 page.browserAction.setIcon("icons/abp-$size-notification-"
60 + notificationType + ".png"); 60 + notificationType + ".png");
61 else 61 else
62 page.browserAction.setIcon("icons/abp-$size" + 62 page.browserAction.setIcon("icons/abp-$size" +
63 (whitelisted ? "-whitelisted" : "") + ".png"); 63 (whitelisted ? "-whitelisted" : "") + ".png");
64 } 64 }
65 else 65 else
66 { 66 {
67 page.browserAction._safeSetIcon({ 67 chrome.browserAction.setIcon({
68 tabId: page.id, 68 tabId: page.id,
69 imageData: frames["" + opacity + whitelisted] 69 imageData: frames["" + opacity + whitelisted]
70 }); 70 });
71 } 71 }
72 } 72 }
73 73
74 FilterNotifier.on("page.WhitelistingStateRevalidate", (page, filter) => 74 FilterNotifier.on("page.WhitelistingStateRevalidate", (page, filter) =>
75 { 75 {
76 whitelistedState.set(page, !!filter); 76 whitelistedState.set(page, !!filter);
77 if (canUpdateIcon) 77 if (canUpdateIcon)
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 clearInterval(interval); 223 clearInterval(interval);
224 resolve(); 224 resolve();
225 return; 225 return;
226 } 226 }
227 227
228 animateIcon(type, frames); 228 animateIcon(type, frames);
229 }, 10000); 229 }, 10000);
230 }); 230 });
231 }); 231 });
232 }; 232 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld