metadata.common - Issue 29367316: Issue 4722 - Drop support for Chrome 41 - 48

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: metadata.common

Issue 29367316: Issue 4722 - Drop support for Chrome 41 - 48 (Closed)

Left Patch Set: Created Dec. 13, 2016, 10:54 a.m.

Right Patch Set: Addressed nit Created Dec. 16, 2016, 10:26 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
1 [general]	1 [general]

2 version = 1.12.4	2 version = 1.12.4

3 backgroundScripts = lib/polyfills/fetch.js	3 backgroundScripts = ext/common.js

4 ext/common.js

5 ext/background.js	4 ext/background.js

6 lib/compat.js	5 lib/compat.js

7 lib/info.js	6 lib/info.js

8 lib/publicSuffixList.js	7 lib/publicSuffixList.js

9 lib/adblockplus.js	8 lib/adblockplus.js

10 messageResponder.js	9 messageResponder.js

11 background.js	10 background.js

12 testScripts = ../ext/common.js	11 testScripts = ../ext/common.js

13 ../ext/background.js	12 ../ext/background.js

14 ../lib/compat.js	13 ../lib/compat.js

(...skipping 105 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
120 addSubscription.label	119 addSubscription.label

121 addSubscriptionAdd.label	120 addSubscriptionAdd.label

122 addSubscriptionOther.label	121 addSubscriptionOther.label

123 acceptableAds2.label	122 acceptableAds2.label

124 viewList.label	123 viewList.label

125 readMore.label	124 readMore.label

126 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	125 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

127 title.label	126 title.label

128 adblockplus/chrome/locale/*/meta.properties = =name	127 adblockplus/chrome/locale/*/meta.properties = =name

129 adblockplusui/locale//firstRun.json = =	128 adblockplusui/locale//firstRun.json = =

LEFT	RIGHT