Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: options.js

Issue 29367316: Issue 4722 - Drop support for Chrome 41 - 48 (Closed)
Patch Set: Addressed nit Created Dec. 16, 2016, 10:26 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « options.html ('k') | subscriptionLink.postload.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: options.js
diff --git a/options.js b/options.js
index c0ed6f788ac502175c8a0cbcc37a688686cc8304..94357cbc88c8ed9ce4572b368a8aa6ad43a3d32e 100644
--- a/options.js
+++ b/options.js
@@ -56,12 +56,7 @@ function wrapper(baseMessage /* , [paramKeys] */)
message[paramKeys[i]] = arguments[i];
}
- // Chrome 30 throws an exception when sendMessage is called with a callback
- // parameter of undefined, so we work around that here. (See issue 4052)
- if (callback)
- ext.backgroundPage.sendMessage(message, callback);
- else
- ext.backgroundPage.sendMessage(message);
+ ext.backgroundPage.sendMessage(message, callback);
};
}
« no previous file with comments | « options.html ('k') | subscriptionLink.postload.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld