Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29368653: No issue - Added new employees with pics and bios (Closed)

Created:
Dec. 16, 2016, 9:11 a.m. by erick
Modified:
Jan. 10, 2017, 5:35 p.m.
Reviewers:
saroyanm
CC:
juliandoucette
Visibility:
Public.

Description

No issue - Added new employees with pics and bios

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed description and pics #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M includes/globals.tmpl View 1 1 chunk +2 lines, -0 lines 0 comments Download
A static/images/people/erick.jpg View 1 Binary file 0 comments Download
A static/images/people/winsley.jpg View 1 Binary file 0 comments Download

Messages

Total messages: 4
erick
Dec. 16, 2016, 9:50 a.m. (2016-12-16 09:50:44 UTC) #1
saroyanm
Almost there https://codereview.adblockplus.org/29368653/diff/29368654/includes/globals.tmpl File includes/globals.tmpl (right): https://codereview.adblockplus.org/29368653/diff/29368654/includes/globals.tmpl#newcode76 includes/globals.tmpl:76: ("2016-12-01", "de", "winsley.png", "Winsley von Spee", "Technical ...
Dec. 19, 2016, 4:53 p.m. (2016-12-19 16:53:30 UTC) #2
erick
On 2016/12/19 16:53:30, saroyanm wrote: > Almost there > > https://codereview.adblockplus.org/29368653/diff/29368654/includes/globals.tmpl > File includes/globals.tmpl (right): ...
Dec. 20, 2016, 10:05 a.m. (2016-12-20 10:05:40 UTC) #3
saroyanm
Dec. 20, 2016, 2:28 p.m. (2016-12-20 14:28:25 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld