Unified Diff: include/AdblockPlus/JsEngine.h
Issue 29369365:
Issue #4692 - Rewrite `SetTimeout` facility to avoid `JsValuePtr` and `JsValueList`
Patch Set:
Created Dec. 19, 2016, 10:24 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
libadblockplus.gyp » ('j')
|
src/GlobalJsObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: include/AdblockPlus/JsEngine.h |
| =================================================================== |
| --- a/include/AdblockPlus/JsEngine.h |
| +++ b/include/AdblockPlus/JsEngine.h |
| @@ -82,9 +82,6 @@ |
| */ |
| class JsEngine : public std::enable_shared_from_this<JsEngine> |
| { |
| - friend class JsValue; |
| - friend class JsContext; |
| - |
| public: |
| /** |
| * Event callback function. |
| @@ -273,9 +270,15 @@ |
| return isolate->Get(); |
| } |
| - private: |
| + protected: |
| explicit JsEngine(const ScopedV8IsolatePtr& isolate); |
| + /** |
| + * Retrieve the global object as a JsValuePtr |
| + * |
| + * \par Precondition |
| + * - Requires a v8 execution scope already present |
| + */ |
| JsValuePtr GetGlobalObject(); |
| /// Isolate must be disposed only after disposing of all objects which are |
| @@ -285,7 +288,6 @@ |
| FileSystemPtr fileSystem; |
| WebRequestPtr webRequest; |
| LogSystemPtr logSystem; |
| - std::unique_ptr<v8::Persistent<v8::Context>> context; |
| EventMap eventCallbacks; |
| // Forward declaration for PImpl idiom |
« no previous file with comments
|
« no previous file
|
libadblockplus.gyp » ('j')
|
src/GlobalJsObject.cpp » ('J')
