Issue 4685 - Update images on eyeo.com

Issue 4685 - Update images on eyeo.com

Images from ps29371563 - https://drive.google.com/open?id=0B9dIRGeSpmZ_V1RNQ1ZSbEdab0U

COLLABORATOR=julian@adblockplus.org
COLLABORATOR=manvel@adblockplus.org

[juliandoucette, 2017-01-10 20:32:25]

On 2016/12/20 17:47:51, erick wrote:

@erick @saroyanm only minor issues here, but it's probably faster for me to
re-implement than comment. I'll submit a new patch and list changes.

[saroyanm, 2017-01-11 09:32:49]

On 2017/01/10 20:32:25, juliandoucette wrote:
> On 2016/12/20 17:47:51, erick wrote:
> 
> @erick @saroyanm only minor issues here, but it's probably faster for me to
> re-implement than comment. I'll submit a new patch and list changes.

Looking forward to your patch.

[juliandoucette, 2017-01-11 17:44:02]

Patch is up.

See description for link to images patch (publicly accessible)

https://codereview.adblockplus.org/29369432/diff/29371563/includes/jobs/offic...
File includes/jobs/office.md (right):

https://codereview.adblockplus.org/29369432/diff/29371563/includes/jobs/offic...
includes/jobs/office.md:3: <p class="image-gallery">
NIT: Do you think I should separate this HTML and markdown into two separate
files? (The same applies to includes/jobs/why.md)

[juliandoucette, 2017-01-11 17:48:09]

A few helpful notes :)

https://codereview.adblockplus.org/29369432/diff/29371563/pages/jobs/index.tmpl
File pages/jobs/index.tmpl (right):

https://codereview.adblockplus.org/29369432/diff/29371563/pages/jobs/index.tm...
pages/jobs/index.tmpl:6: .image-gallery a
Note: a overflow: hidden and max-width: 150px crops wide images (so that they
all appear on one line)

https://codereview.adblockplus.org/29369432/diff/29371563/pages/jobs/index.tm...
pages/jobs/index.tmpl:21: <script src="/js/jquery.lightbox.min.js"></script>
Note: Moved from include into page head.

https://codereview.adblockplus.org/29369432/diff/29371563/pages/press.html
File pages/press.html (right):

https://codereview.adblockplus.org/29369432/diff/29371563/pages/press.html#ne...
pages/press.html:7: vertical-align: middle;
Note: a line-height and img vertical-align vertically center the wide eyeo logo.

https://codereview.adblockplus.org/29369432/diff/29371563/pages/press.html#ne...
pages/press.html:22: <script>
Note: Moved from include into page head.

[juliandoucette, 2017-01-12 15:32:38]

Notes from review meeting.

https://codereview.adblockplus.org/29369432/diff/29371563/includes/jobs/offic...
File includes/jobs/office.md (right):

https://codereview.adblockplus.org/29369432/diff/29371563/includes/jobs/offic...
includes/jobs/office.md:3: <p class="image-gallery">
On 2017/01/11 17:44:02, juliandoucette wrote:
> NIT: Do you think I should separate this HTML and markdown into two separate
> files? (The same applies to includes/jobs/why.md)

Done.

https://codereview.adblockplus.org/29369432/diff/29371563/pages/jobs/index.tmpl
File pages/jobs/index.tmpl (right):

https://codereview.adblockplus.org/29369432/diff/29371563/pages/jobs/index.tm...
pages/jobs/index.tmpl:6: .image-gallery a
On 2017/01/11 17:48:09, juliandoucette wrote:
> Note: a overflow: hidden and max-width: 150px crops wide images (so that they
> all appear on one line)

Acknowledged.

https://codereview.adblockplus.org/29369432/diff/29371563/pages/jobs/index.tm...
pages/jobs/index.tmpl:21: <script src="/js/jquery.lightbox.min.js"></script>
On 2017/01/11 17:48:09, juliandoucette wrote:
> Note: Moved from include into page head.

Acknowledged.

https://codereview.adblockplus.org/29369432/diff/29371563/pages/press.html
File pages/press.html (right):

https://codereview.adblockplus.org/29369432/diff/29371563/pages/press.html#ne...
pages/press.html:7: vertical-align: middle;
On 2017/01/11 17:48:09, juliandoucette wrote:
> Note: a line-height and img vertical-align vertically center the wide eyeo
logo.

Acknowledged.

https://codereview.adblockplus.org/29369432/diff/29371563/pages/press.html#ne...
pages/press.html:22: <script>
On 2017/01/11 17:48:09, juliandoucette wrote:
> Note: Moved from include into page head.

Acknowledged.

[saroyanm, 2017-01-12 15:41:15]

LGTM

[juliandoucette, 2017-01-17 02:13:38]

On 2017/01/12 15:41:15, saroyanm wrote:
> LGTM

https://hg.adblockplus.org/web.eyeo.com/rev/79bead875880