Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(233)

Issue 29369432: Issue 4685 - Update images on eyeo.com (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by erick
Modified:
2 years, 9 months ago
Visibility:
Public.

Description

Issue 4685 - Update images on eyeo.com Images from ps29371563 - https://drive.google.com/open?id=0B9dIRGeSpmZ_V1RNQ1ZSbEdab0U COLLABORATOR=julian@adblockplus.org COLLABORATOR=manvel@adblockplus.org

Patch Set 1 #

Patch Set 2 : See notes in comments #

Total comments: 10

Patch Set 3 : See notes from previous changeset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -44 lines) Patch
M includes/jobs/office.md View 1 2 1 chunk +1 line, -19 lines 0 comments Download
A includes/jobs/office-gallery.html View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M includes/jobs/why.md View 1 2 1 chunk +1 line, -1 line 0 comments Download
A includes/jobs/why-gallery.html View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M includes/press/media.md View 1 2 1 chunk +1 line, -14 lines 0 comments Download
A includes/press/media-gallery.html View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M pages/index.html View 1 1 chunk +1 line, -1 line 0 comments Download
M pages/jobs/index.tmpl View 1 1 chunk +22 lines, -0 lines 0 comments Download
M pages/press.html View 1 2 1 chunk +27 lines, -9 lines 0 comments Download
M static/images/jobs/why/office-1.png View 1 2 Binary file 0 comments Download
M static/images/jobs/why/office-2.png View 1 2 Binary file 0 comments Download

Messages

Total messages: 8
erick
2 years, 10 months ago (2016-12-20 17:47:51 UTC) #1
juliandoucette
On 2016/12/20 17:47:51, erick wrote: @erick @saroyanm only minor issues here, but it's probably faster ...
2 years, 9 months ago (2017-01-10 20:32:25 UTC) #2
saroyanm
On 2017/01/10 20:32:25, juliandoucette wrote: > On 2016/12/20 17:47:51, erick wrote: > > @erick @saroyanm ...
2 years, 9 months ago (2017-01-11 09:32:49 UTC) #3
juliandoucette
Patch is up. See description for link to images patch (publicly accessible) https://codereview.adblockplus.org/29369432/diff/29371563/includes/jobs/office.md File includes/jobs/office.md ...
2 years, 9 months ago (2017-01-11 17:44:02 UTC) #4
juliandoucette
A few helpful notes :) https://codereview.adblockplus.org/29369432/diff/29371563/pages/jobs/index.tmpl File pages/jobs/index.tmpl (right): https://codereview.adblockplus.org/29369432/diff/29371563/pages/jobs/index.tmpl#newcode6 pages/jobs/index.tmpl:6: .image-gallery a Note: a ...
2 years, 9 months ago (2017-01-11 17:48:09 UTC) #5
juliandoucette
Notes from review meeting. https://codereview.adblockplus.org/29369432/diff/29371563/includes/jobs/office.md File includes/jobs/office.md (right): https://codereview.adblockplus.org/29369432/diff/29371563/includes/jobs/office.md#newcode3 includes/jobs/office.md:3: <p class="image-gallery"> On 2017/01/11 17:44:02, ...
2 years, 9 months ago (2017-01-12 15:32:38 UTC) #6
saroyanm
LGTM
2 years, 9 months ago (2017-01-12 15:41:15 UTC) #7
juliandoucette
2 years, 9 months ago (2017-01-17 02:13:38 UTC) #8
On 2017/01/12 15:41:15, saroyanm wrote:
> LGTM

https://hg.adblockplus.org/web.eyeo.com/rev/79bead875880
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5