Issue 29369476: Issue 4471 - Added AdRecover to the Acceptable Ads Providers widget

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29369476: Issue 4471 - Added AdRecover to the Acceptable Ads Providers widget (Closed)

Created:
Dec. 21, 2016, 5:34 p.m. by erick

Modified:
Jan. 10, 2017, 4:44 p.m.

Reviewers:
juliandoucette, saroyanm

Visibility:
Public.

Description

Issue 4471 - Added AdRecover to the Acceptable Ads Providers widget

Patch Set 1 #

Total comments: 2

Created: Dec. 21, 2016, 5:34 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	includes/solutions/providers.md	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

saroyanm

@Julian you want to review this as well, while it's related to AA ?

Jan. 9, 2017, 8:23 a.m. (2017-01-09 08:23:56 UTC) #2

juliandoucette

LGTM https://codereview.adblockplus.org/29369476/diff/29369477/includes/solutions/providers.md File includes/solutions/providers.md (right): https://codereview.adblockplus.org/29369476/diff/29369477/includes/solutions/providers.md#newcode19 includes/solutions/providers.md:19: - [AdRecover](http://adrecover.com){: target=blank } NIT: We seem to ...

Jan. 9, 2017, 6:21 p.m. (2017-01-09 18:21:42 UTC) #3

juliandoucette

Jan. 9, 2017, 6:29 p.m. (2017-01-09 18:29:47 UTC) #4

https://codereview.adblockplus.org/29369476/diff/29369477/includes/solutions/...
File includes/solutions/providers.md (right):

https://codereview.adblockplus.org/29369476/diff/29369477/includes/solutions/...
includes/solutions/providers.md:19: - [AdRecover](http://adrecover.com){:
target=blank }
On 2017/01/09 18:21:42, juliandoucette wrote:
> NIT: We seem to be using fully resolved URLs above (EG: http://adrecover.com
> resolves to https://www.adrecover.com/). I think we should consider dropping
> "http(s):" because most browsers will automatically detect the correct
> http/https (favoring https) and this may prevent potential protocol errors
(when
> a third party website expects https but allows http and this results in mixed
> responses).
> 
> On one hand, we could change this to a fully resolved URL to be consistent. On
> the other, it doesn't matter because the URL resolves correctly. As a result,
I
> think we should push this and address the http/https issue separately.

Created issue: https://issues.adblockplus.org/ticket/4782

Expand All Messages | Collapse All Messages