Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/JsEngine.h

Issue 29369479: Issue #4694 - Add mutex protection to JS event handling
Patch Set: Created Dec. 21, 2016, 7:35 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | libadblockplus.gyp » ('j') | src/Event.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/JsEngine.h
===================================================================
--- a/include/AdblockPlus/JsEngine.h
+++ b/include/AdblockPlus/JsEngine.h
@@ -40,6 +40,11 @@
typedef Handle<Value>(*InvocationCallback)(const Arguments &args);
}
+/*
+ * Forward declaration of internally-defined implementation class
+ */
+class JsEngineInternal;
+
namespace AdblockPlus
{
class JsEngine;
@@ -281,6 +286,12 @@
*/
JsValuePtr GetGlobalObject();
+ /**
+ * Provide a reference to this object in its type as constructed.
+ * Objects of this type are only ever constructed as `JsEngineInternal`.
+ */
+ JsEngineInternal& Internal();
+
/// Isolate must be disposed only after disposing of all objects which are
/// using it.
ScopedV8IsolatePtr isolate;
@@ -288,7 +299,6 @@
FileSystemPtr fileSystem;
WebRequestPtr webRequest;
LogSystemPtr logSystem;
- EventMap eventCallbacks;
// Forward declaration for PImpl idiom
class SchedulerImpl;
« no previous file with comments | « no previous file | libadblockplus.gyp » ('j') | src/Event.h » ('J')

Powered by Google App Engine
This is Rietveld