[adblockpluscore] Issue 4762 - Added "relentless" notification that shows up in intervals

test/notification.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 389 matching lines @@
   let relentless = {
     id: 3,
     type: "relentless",
     interval: 100,
     urlFilters: ["foo.com$document", "bar.foo$document"]
   };
 
   registerHandler.call(this, [relentless]);
   this.runScheduledTasks(1).then(() =>
   {
-    test.deepEqual(showNotifications(), [], "Relentless notification is not shown without url");

[Felix Dahlke, 2017/01/20 09:51:37]

Nit: "url" -> "URL"?

[wspee, 2017/01/20 10:26:13]

Done.

-    test.deepEqual(showNotifications("http://bar.com"), [], "Relentless notification is not shown to the wrong url");

[Felix Dahlke, 2017/01/20 09:51:36]

Nit: "shown to the wrong url" -> "shown for a non-matching URL"?

[wspee, 2017/01/20 10:26:13]

Done.

-    test.deepEqual(showNotifications("http://foo.com"), [relentless], "Relentless notification is shown to correct url");

[Felix Dahlke, 2017/01/20 09:51:37]

Nit: "shown to correct url" "shown for a matching URL"?

[wspee, 2017/01/20 10:26:13]

Done.

+    test.deepEqual(showNotifications(), [], "Relentless notification is not shown without URL");
+    test.deepEqual(showNotifications("http://bar.com"), [], "Relentless notification is not shown for a non-matching URL");
+    test.deepEqual(showNotifications("http://foo.com"), [relentless], "Relentless notification is shown for a matching URL");
   }).then(() =>
   {
     test.deepEqual(showNotifications("http://foo.com"), [], "Relentless notifications are not shown before the interval");
   }).then(() =>
   {
     // Date always returns a fixed time (see setupTimerAndXMLHttp) so we
     // manipulate the shown data manually.
     Prefs.notificationdata.shown[relentless.id] -= relentless.interval;
-    test.deepEqual(showNotifications(), [], "Relentless notifications are not shown after the interval without url");

[Felix Dahlke, 2017/01/20 09:51:37]

Nit: "url" -> "URL"?

[wspee, 2017/01/20 10:26:13]

Done.

-    test.deepEqual(showNotifications("http://bar.com"), [], "Relentless notifications are not shown after the interval to the wrong url");

[Felix Dahlke, 2017/01/20 09:51:36]

Nit: "to the wrong url" -> "for a non-matching URL"?

[wspee, 2017/01/20 10:26:13]

Done.

-    test.deepEqual(showNotifications("http://bar.foo.com"), [relentless], "Relentless notifications are shown after the interval to the correct url");

[Felix Dahlke, 2017/01/20 09:51:37]

Nit: "to the correct url" -> "for a matching URL"?

[wspee, 2017/01/20 10:26:13]

Done.

+    test.deepEqual(showNotifications(), [], "Relentless notifications are not shown after the interval without URL");
+    test.deepEqual(showNotifications("http://bar.com"), [], "Relentless notifications are not shown after the interval for a non-matching URL");
+    test.deepEqual(showNotifications("http://bar.foo.com"), [relentless], "Relentless notifications are shown after the interval for a matching URL");
   }).catch(unexpectedError.bind(test)).then(() => test.done());
 };
 
 exports.testGlobalOptOut = function(test)
 {
   Notification.toggleIgnoreCategory("*", true);
   test.ok(Prefs.notifications_ignoredcategories.indexOf("*") != -1, "Force enable global opt-out");
   Notification.toggleIgnoreCategory("*", true);
   test.ok(Prefs.notifications_ignoredcategories.indexOf("*") != -1, "Force enable global opt-out (again)");
   Notification.toggleIgnoreCategory("*", false);
@@ skipping 79 matching lines @@
   test.done();
 };
 
 exports.testMissingTranslation = function(test)
 {
   let notification = {message: {"en-US": "en-US"}};
   let texts = Notification.getLocalizedTexts(notification, "fr");
   test.equal(texts.message, "en-US");
   test.done();
 };