Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/antiadblockInit.js

Issue 29370594: [adblockplusui] Issue 4915 - Define ext for background pages in antiadblockInit.js (Closed)
Patch Set: Simplified ext assigning expression Created March 1, 2017, 2:52 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/antiadblockInit.js
diff --git a/lib/antiadblockInit.js b/lib/antiadblockInit.js
index ac9ef424ab902bf0c3c18a0e0771a6b840d7a429..c7f23b74c27f55b8ccdd055ba39f3857250858a6 100644
--- a/lib/antiadblockInit.js
+++ b/lib/antiadblockInit.js
@@ -25,6 +25,9 @@ let {FilterNotifier} = require("filterNotifier");
let {Subscription} = require("subscriptionClasses");
let {Notification} = require("notification");
+let ext = typeof window != "undefined" &&
kzar 2017/03/02 09:36:30 I'm not sure this is right, since if ext is alread
Wladimir Palant 2017/03/02 11:14:39 This part is unproblematic, it's a module which me
Thomas Greiner 2017/03/02 11:41:16 I assume the confusion here comes from the fact th
wspee 2017/03/03 09:25:21 Done. Any objections?
+ window.ext || require("ext_background");
+
exports.initAntiAdblockNotification = function initAntiAdblockNotification()
{
let notification = {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld