Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(724)

Issue 29370610: Issue 4760 - Change Ad blocking settings text (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by diegocarloslima
Modified:
3 years, 5 months ago
Reviewers:
Felix Dahlke
CC:
anton, René Jeschke
Visibility:
Public.

Description

Issue 4760 - Change Ad blocking settings text

Patch Set 1 #

Total comments: 1

Patch Set 2 : Renaming category_filters to category_languages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M mobile/android/base/locales/adblockbrowser/en-US/android_strings.dtd View 1 1 chunk +8 lines, -6 lines 0 comments Download
M mobile/android/base/resources/xml-v11/preferences.xml View 1 chunk +1 line, -1 line 0 comments Download
M mobile/android/base/resources/xml-v11/preferences_abb_abp.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mobile/android/base/resources/xml/preferences.xml View 1 chunk +1 line, -1 line 0 comments Download
M mobile/android/base/resources/xml/preferences_abb_abp.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download
M mobile/android/base/strings.xml.in View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3
diegocarloslima
3 years, 5 months ago (2017-01-02 16:09:37 UTC) #1
Felix Dahlke
Looks good, just one naming thing. https://codereview.adblockplus.org/29370610/diff/29370611/mobile/android/base/resources/xml-v11/preferences_abb_abp.xml File mobile/android/base/resources/xml-v11/preferences_abb_abp.xml (right): https://codereview.adblockplus.org/29370610/diff/29370611/mobile/android/base/resources/xml-v11/preferences_abb_abp.xml#newcode17 mobile/android/base/resources/xml-v11/preferences_abb_abp.xml:17: <PreferenceScreen android:title="@string/abb_pref_category_filters" I'd ...
3 years, 5 months ago (2017-01-02 16:48:20 UTC) #2
Felix Dahlke
3 years, 5 months ago (2017-01-02 18:32:29 UTC) #3
Nice, LGTM!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5