Issue 4733 - Refactor nginx module

modules/nginx/manifests/init.pp

 class nginx (
     $worker_processes = $nginx::params::worker_processes,
     $worker_connections = $nginx::params::worker_connections,
     $ssl_session_cache =  $nginx::params::ssl_session_cache,
     $geoip_country = undef,
     $geoip_city = undef,
   ) inherits nginx::params {
 
   # Class['ssh'] is assumed to handle SSL-related quirks and therefore
   # the inclusion here became necessary.
@@ skipping 25 matching lines @@
 
   if $::operatingsystem == 'Debian' {
 
     apt::key {'nginx':
       key => 'ABF5BD827BD9BF62',
       key_content => template('nginx/apt.key.erb'),
     }
 
     apt::source {'nginx':
       before => Package['nginx'],
-      location => 'http://nginx.org/packages/mainline/debian/',

[Fred, 2017/01/03 15:09:46]

Since we added "apt-transport-https" in the Vagrantfile in this patchset, why
not use https here then?

[f.lopez, 2017/01/03 16:34:24]

Nice catch, ack

+      location => 'https://nginx.org/packages/mainline/debian/',
       release => downcase($::lsbdistcodename),
       repos => 'nginx',
       require => Apt::Key['nginx'],
     }
   }
 
   user {'nginx':
     ensure => 'present',
     require => Package['nginx'],
   }
@@ skipping 180 matching lines @@
 
   Service['nginx'] <~ Class['ssh']
 
   file {'/usr/share/nginx/html/50x.html':
     mode => 0644,
     owner => 'root',
     require => Package['nginx'],
     source => 'puppet:///modules/nginx/50x.html',
   }
 }