Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(237)

Issue 29370727: Issue 4505 - Add translations (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by diegocarloslima
Modified:
2 years, 8 months ago
Reviewers:
anton, Felix Dahlke
CC:
René Jeschke
Visibility:
Public.

Description

Issue 4505 - Add translations

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removing now unused readTextFile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+395 lines, -39 lines) Patch
R res/raw/aa_dialog.html View 1 chunk +0 lines, -2 lines 0 comments Download
R res/raw/sbrowser_dialog.html View 1 chunk +0 lines, -2 lines 0 comments Download
R res/raw/setup_dialog.html View 1 chunk +0 lines, -2 lines 0 comments Download
A res/values-de/strings.xml View 1 chunk +35 lines, -0 lines 0 comments Download
A res/values-el/strings.xml View 1 chunk +35 lines, -0 lines 0 comments Download
A res/values-es/strings.xml View 1 chunk +35 lines, -0 lines 0 comments Download
A res/values-fr/strings.xml View 1 chunk +35 lines, -0 lines 0 comments Download
A res/values-it/strings.xml View 1 chunk +35 lines, -0 lines 0 comments Download
A res/values-ko/strings.xml View 1 chunk +35 lines, -0 lines 0 comments Download
A res/values-nl/strings.xml View 1 chunk +35 lines, -0 lines 0 comments Download
A res/values-pl/strings.xml View 1 chunk +35 lines, -0 lines 0 comments Download
A res/values-pt/strings.xml View 1 chunk +35 lines, -0 lines 0 comments Download
A res/values-ru/strings.xml View 1 chunk +35 lines, -0 lines 0 comments Download
A res/values-tr/strings.xml View 1 chunk +35 lines, -0 lines 0 comments Download
M res/values/arrays.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M res/values/strings.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M src/org/adblockplus/sbrowser/contentblocker/MainPreferences.java View 1 4 chunks +3 lines, -31 lines 0 comments Download

Messages

Total messages: 5
diegocarloslima
2 years, 8 months ago (2017-01-04 17:27:41 UTC) #1
Felix Dahlke
LGTM (with one question), but here's another one: What about upload to and download from ...
2 years, 8 months ago (2017-01-06 09:31:48 UTC) #2
diegocarloslima
I also do agree that the more we automate the translation process (through translations.py + ...
2 years, 8 months ago (2017-01-06 14:55:40 UTC) #3
Felix Dahlke
https://codereview.adblockplus.org/29370727/diff/29370728/res/values/strings.xml File res/values/strings.xml (right): https://codereview.adblockplus.org/29370727/diff/29370728/res/values/strings.xml#newcode21 res/values/strings.xml:21: <string name="aa_dialog_message"><![CDATA[Annoying ads are always blocked, while nonintrusive ads ...
2 years, 8 months ago (2017-01-06 15:05:41 UTC) #4
anton
2 years, 8 months ago (2017-01-09 09:58:45 UTC) #5
On 2017/01/04 17:27:41, diegocarloslima wrote:

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5