Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29370944: NoIssue - Write fail2ban configuration for CVE-2013-0235 on web2 (Closed)

Created:
Jan. 10, 2017, 3:58 a.m. by f.lopez
Modified:
Jan. 23, 2017, 3:32 p.m.
Reviewers:
mathias, f.nicolaisen
CC:
Fred
Visibility:
Public.

Description

NoIssue - Write fail2ban configuration for CVE-2013-0235 on web2

Patch Set 1 #

Patch Set 2 : Fixing call function inside template #

Patch Set 3 : Remove unrelated change from codereview #

Total comments: 1

Patch Set 4 : For comments 9 to 11 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
A modules/private-stub/hiera/hosts/web2.yaml View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 14
f.lopez
Jan. 10, 2017, 3:58 a.m. (2017-01-10 03:58:42 UTC) #1
f.nicolaisen
The example private stub change affects a single host. Does it maybe make sense to ...
Jan. 10, 2017, 8:11 a.m. (2017-01-10 08:11:48 UTC) #2
f.nicolaisen
Is this patch related to https://issues.adblockplus.org/ticket/4701 btw?
Jan. 10, 2017, 9:05 a.m. (2017-01-10 09:05:21 UTC) #3
f.lopez
On 2017/01/10 09:05:21, f.nicolaisen wrote: > Is this patch related to https://issues.adblockplus.org/ticket/4701 btw? No, that's ...
Jan. 11, 2017, 3:37 p.m. (2017-01-11 15:37:45 UTC) #4
f.lopez
Jan. 11, 2017, 4:04 p.m. (2017-01-11 16:04:47 UTC) #5
f.lopez
On 2017/01/10 08:11:48, f.nicolaisen wrote: > The example private stub change affects a single host. ...
Jan. 11, 2017, 4:05 p.m. (2017-01-11 16:05:59 UTC) #6
mathias
> On 2017/01/10 09:05:21, f.nicolaisen wrote: > Is this patch related to https://issues.adblockplus.org/ticket/4701 btw? On ...
Jan. 11, 2017, 4:10 p.m. (2017-01-11 16:10:41 UTC) #7
f.lopez
Jan. 11, 2017, 4:42 p.m. (2017-01-11 16:42:00 UTC) #8
f.nicolaisen
https://codereview.adblockplus.org/29370944/diff/29371561/modules/private-stub/hiera/hosts/web2.yaml File modules/private-stub/hiera/hosts/web2.yaml (right): https://codereview.adblockplus.org/29370944/diff/29371561/modules/private-stub/hiera/hosts/web2.yaml#newcode8 modules/private-stub/hiera/hosts/web2.yaml:8: logpath: '/var/log/nginx/access_log_hg' vagrant@web2:~$ less /var/log/nginx/access_log_hg /var/log/nginx/access_log_hg: No such file ...
Jan. 12, 2017, 2:28 p.m. (2017-01-12 14:28:14 UTC) #9
f.lopez
On 2017/01/12 14:28:14, f.nicolaisen wrote: > https://codereview.adblockplus.org/29370944/diff/29371561/modules/private-stub/hiera/hosts/web2.yaml > File modules/private-stub/hiera/hosts/web2.yaml (right): > > https://codereview.adblockplus.org/29370944/diff/29371561/modules/private-stub/hiera/hosts/web2.yaml#newcode8 > ...
Jan. 12, 2017, 2:42 p.m. (2017-01-12 14:42:43 UTC) #10
f.nicolaisen
On 2017/01/12 14:42:43, f.lopez wrote: > On 2017/01/12 14:28:14, f.nicolaisen wrote: > > > https://codereview.adblockplus.org/29370944/diff/29371561/modules/private-stub/hiera/hosts/web2.yaml ...
Jan. 12, 2017, 3:16 p.m. (2017-01-12 15:16:50 UTC) #11
f.lopez
Jan. 12, 2017, 3:40 p.m. (2017-01-12 15:40:46 UTC) #12
f.nicolaisen
LGTM
Jan. 12, 2017, 4:04 p.m. (2017-01-12 16:04:21 UTC) #13
mathias
Jan. 18, 2017, 10:28 a.m. (2017-01-18 10:28:49 UTC) #14
LGTM.

Powered by Google App Engine
This is Rietveld