Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/filterComposer.js

Issue 29370947: Issue 3138 - Improve how context menu "block element" handles iframes (Closed)
Patch Set: Use messaging instead of requiring the info module Created Oct. 19, 2017, 10:52 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ext/background.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 filters.push(docDomain.replace(/^www\./, "") + "##" + selector); 162 filters.push(docDomain.replace(/^www\./, "") + "##" + selector);
163 } 163 }
164 } 164 }
165 165
166 return {filters, selectors}; 166 return {filters, selectors};
167 } 167 }
168 168
169 let contextMenuItem = { 169 let contextMenuItem = {
170 title: browser.i18n.getMessage("block_element"), 170 title: browser.i18n.getMessage("block_element"),
171 contexts: ["image", "video", "audio"], 171 contexts: ["image", "video", "audio"],
172 onclick(page) 172 onclick(page, info)
173 { 173 {
174 page.sendMessage({type: "composer.content.contextMenuClicked"}); 174 page.sendMessage(
175 {type: "composer.content.contextMenuClicked"}, undefined, info.frameId
176 );
175 } 177 }
176 }; 178 };
177 179
178 function updateContextMenu(page, filter) 180 function updateContextMenu(page, filter)
179 { 181 {
180 page.contextMenus.remove(contextMenuItem); 182 page.contextMenus.remove(contextMenuItem);
181 183
182 if (typeof filter == "undefined") 184 if (typeof filter == "undefined")
183 filter = checkWhitelisted(page); 185 filter = checkWhitelisted(page);
184 186
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 265
264 port.on("composer.quoteCSS", (message, sender) => 266 port.on("composer.quoteCSS", (message, sender) =>
265 { 267 {
266 return quoteCSS(message.CSS); 268 return quoteCSS(message.CSS);
267 }); 269 });
268 270
269 ext.pages.onLoading.addListener(page => 271 ext.pages.onLoading.addListener(page =>
270 { 272 {
271 page.sendMessage({type: "composer.content.finished"}); 273 page.sendMessage({type: "composer.content.finished"});
272 }); 274 });
OLDNEW
« no previous file with comments | « ext/background.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld