Issue 3138 - Improve how context menu "block element" handles iframes

chrome/ext/background.js

Index: chrome/ext/background.js
diff --git a/chrome/ext/background.js b/chrome/ext/background.js
index 4681ec08bb0fbf200b337c74cd8d33e09d754c26..adb89347f07ba9b48e74fcc6b89dbcd1b05c0df5 100644
--- a/chrome/ext/background.js
+++ b/chrome/ext/background.js
@@ -46,9 +46,12 @@
           return frame.url;
       }
     },
-    sendMessage: function(message, responseCallback)
+    sendMessage: function(message, responseCallback, frameId)
     {
-      chrome.tabs.sendMessage(this.id, message, responseCallback);
+      let options = {};
+      if (frameId != undefined)

[Sebastian Noack, 2017/01/11 18:15:11]

Please use typeof to check for undefined, like we do everywhere else.

[kzar, 2017/01/12 07:24:04]

Whoops, Done.

+        options.frameId = frameId;

[Sebastian Noack, 2017/01/11 18:15:11]

This isn't supported in Microsoft Edge. Regardless, I'm not too happy with
extending ext.* but would rather prefer to finally target the browserext API.

[kzar, 2017/01/12 07:24:04]

Damn, looking at the docs it seems like you're right. Apparently browserext does
specify the frameId option but Edge didn't implement that yet. Without this I
don't see how we can work around the problem for Edge. (Well actually I do, we
could have a similar workaround as on Safari where each frame generates a random
number, sends that to the background and then the background includes that in
messages sent to frames. Seems like overkill here however...) For now I suppose
we could add a check in the content script to avoid using the frame element if
we don't think per frame messaging is working.
Well I'd prefer not to extend ext further too but for now I can't see how else
to do it.

Switching to browserext is a huge job which while I've made some progress
towards, is not even ready for review yet. Then we still need to remove ext
which is another huge job as far as I can see. 

If you'd rather mark this issue as being blocked by the migration then fair
enough, but it seems overkill IMO.

+      chrome.tabs.sendMessage(this.id, message, options, responseCallback);
     }
   };
 
@@ -328,7 +331,7 @@
             contexts: item.contexts,
             onclick: function(info, tab)
             {
-              item.onclick(new Page(tab));
+              item.onclick(new Page(tab), info);
             }
           });
         });