Unified Diff: test/BaseJsTest.cpp
Issue 29370977:
Issue #3593 - Stop sharing a single isolate amongst all unit tests
Patch Set:
Created Jan. 10, 2017, 6:52 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
test/FilterEngine.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/BaseJsTest.cpp |
| =================================================================== |
| --- a/test/BaseJsTest.cpp |
| +++ b/test/BaseJsTest.cpp |
| @@ -20,8 +20,7 @@ |
| AdblockPlus::JsEnginePtr CreateJsEngine(const AdblockPlus::AppInfo& appInfo) |
| { |
| - static AdblockPlus::ScopedV8IsolatePtr isolate = std::make_shared<AdblockPlus::ScopedV8Isolate>(); |
| - return AdblockPlus::JsEngine::New(appInfo, isolate); |
| + return AdblockPlus::JsEngine::New(appInfo); |
| } |
| void BaseJsTest::SetUp() |
| @@ -35,4 +34,6 @@ |
| void BaseJsTest::TearDown() |
| { |
| ToInternal(jsEngine)->WaitForQuietScheduler(); |
| + jsEngine.reset(); |
| + EXPECT_EQ(0, jsEngine.use_count()); |
| } |
« no previous file with comments
|
« no previous file
|
test/FilterEngine.cpp » ('j')
|
no next file with comments »
