Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/JsEngineInternal.h

Issue 29371607: Issue #3593 - Make isolate a fully internal member of the engine
Patch Set: improve unit tests to go with isolate change Created Jan. 16, 2017, 3:53 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/JsEngine.cpp ('k') | test/AppInfoJsObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/JsEngineInternal.h
===================================================================
--- a/src/JsEngineInternal.h
+++ b/src/JsEngineInternal.h
@@ -94,7 +94,7 @@
void ScheduleTaskInternal(std::shared_ptr<TaskFunctionInterface>&& body);
public:
- JsEngineInternal(const AdblockPlus::ScopedV8IsolatePtr& isolate);
+ JsEngineInternal(v8::Isolate* isolate);
/**
* Retrieve our persistent v8 context as a local handle.
« no previous file with comments | « src/JsEngine.cpp ('k') | test/AppInfoJsObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld