Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/BaseJsTest.cpp

Issue 29371607: Issue #3593 - Make isolate a fully internal member of the engine
Patch Set: improve unit tests to go with isolate change Created Jan. 16, 2017, 3:53 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/BaseJsTest.h ('k') | test/ConsoleJsObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/BaseJsTest.cpp
===================================================================
--- a/test/BaseJsTest.cpp
+++ b/test/BaseJsTest.cpp
@@ -26,14 +26,14 @@
void BaseJsTest::SetUp()
{
jsEngine = CreateJsEngine();
- jsEngine->SetLogSystem(AdblockPlus::LogSystemPtr(new ThrowingLogSystem));
- jsEngine->SetFileSystem(AdblockPlus::FileSystemPtr(new ThrowingFileSystem));
- jsEngine->SetWebRequest(AdblockPlus::WebRequestPtr(new ThrowingWebRequest));
+ jsEngine->SetLogSystem(std::make_shared<ThrowingLogSystem>());
+ jsEngine->SetFileSystem(std::make_shared<ThrowingFileSystem>());
+ jsEngine->SetWebRequest(std::make_shared<ThrowingWebRequest>());
}
void BaseJsTest::TearDown()
{
ToInternal(jsEngine)->WaitForQuietScheduler();
+ EXPECT_EQ(1, jsEngine.use_count());
jsEngine.reset();
- EXPECT_EQ(0, jsEngine.use_count());
}
« no previous file with comments | « test/BaseJsTest.h ('k') | test/ConsoleJsObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld