Unified Diff: test/Prefs.cpp
Issue 29371607:
Issue #3593 - Make isolate a fully internal member of the engine
Patch Set: improve unit tests to go with isolate change
Created Jan. 16, 2017, 3:53 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« test/Notification.cpp ('k')
|
test/UpdateCheck.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/Prefs.cpp |
| =================================================================== |
| --- a/test/Prefs.cpp |
| +++ b/test/Prefs.cpp |
| @@ -32,7 +32,7 @@ |
| std::shared_ptr<std::istream> Read(const std::string& path) const |
| { |
| if (path == "prefs.json" && !prefsContents.empty()) |
| - return std::shared_ptr<std::istream>(new std::istringstream(prefsContents)); |
| + return std::make_shared<std::istringstream>(prefsContents); |
| return LazyFileSystem::Read(path); |
| } |
| @@ -115,8 +115,8 @@ |
| { |
| filterEngine.reset(); |
| ToInternal(jsEngine)->WaitForQuietScheduler(); |
| + EXPECT_EQ(1, jsEngine.use_count()); |
| jsEngine.reset(); |
| - EXPECT_EQ(0, jsEngine.use_count()); |
| } |
| }; |
| } |
« no previous file with comments
|
« test/Notification.cpp ('k')
|
test/UpdateCheck.cpp » ('j')
|
no next file with comments »
